Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipselink-dev] Exclude QueryTimeoutTest from Core SRG?

I looked a litter further and I am ok with excluding these tests from the SRG and moving them to the LRG.

'anyone have any objections?

org.eclipse.persistence.testing.tests.queries.QueryTimeoutTest

org.eclipse.persistence.testing.tests.queries.QueryTimeoutConnectionReleasedTest

-Tom

Goerler, Adrian wrote:
Hi Tom,

we were under the impression that it is not allowed to skip tests from the SRG:

http://wiki.eclipse.org/EclipseLink/Development/Incubator/Extensions/DatabasePlatformPromotion#Basic_Test_Suites_required_for_inclusion

"In the case of the Core SRG if it is not possible to pass a test in the platform you are creating, a discussion should be started on the developer mailing list about *excluding the test from the SRG*."

Our interpretation of this sentence was that it is not allowed to skip a test of the Core SRG. If a Core SRG test needs to be skipped on a database either the database does not qualify for "inclusion" or the test should not be part of the Core SRG.

Anyhow, we will skip these test on MaxDB and can decide about excluding the tests from Core SRG later.

-Adrian SAP AG
Dietmar-Hopp-Allee 16, 69190 Walldorf, Germany

Sitz der Gesellschaft/Registered Office: Walldorf, Germany
Vorstand/SAP Executive Board: Henning Kagermann (Sprecher/CEO), Léo Apotheker (stellvertretender Sprecher/Deputy CEO), Werner Brandt, Claus Heinrich, Gerhard Oswald, John Schwarz, Peter Zencke
Vorsitzender des Aufsichtsrats/Chairperson of the SAP Supervisory Board: Hasso Plattner
Registergericht/Commercial Register Mannheim No HRB 350269
-----Urspr√ľngliche Nachricht-----
Von: eclipselink-dev-bounces@xxxxxxxxxxx [mailto:eclipselink-dev-bounces@xxxxxxxxxxx] Im Auftrag von Tom Ware
Gesendet: Mittwoch, 29. September 2010 15:13
An: Dev mailing list for Eclipse Persistence Services
Betreff: Re: [eclipselink-dev] Exclude QueryTimeoutTest from Core SRG?

Hi Sabine,

The requirement is actually that there are no failures in the Core SRG. Skipping a test with committer approval satisfies that requirement. Unless there is a committer who disagrees, adding code to skip the test in MaxDB similar to the Symfoware code is ok.

I am ok with that change. I assume any committer who disagrees with that change will respond to this email today.

-Tom

Heider, Sabine wrote:
Hi,
MaxDB's JDBC driver doesn't support the setQueryTimeout method as documented in _bug 326503_ <https://bugs.eclipse.org/bugs/show_bug.cgi?id=326503>. Due to this limitation, the following tests fail: org.eclipse.persistence.testing.tests.queries.QueryTimeoutTest

org.eclipse.persistence.testing.tests.queries.QueryTimeoutConn
ectionReleasedTest
QueryTimeoutTest is part of the Core SRG test suite, and
according to
the rules for database platform promotion, a platform is
required to
pass Core SRG without failures.
Both tests are skipped for the Symfoware platform where the same limitation applies. I guess, however, that this was done before the rules for database platform promotion have been set up in
this form,
wasn't it? How should we proceed here? Should the QueryTimeoutTest rather be excluded from Core SRG? Thanks for your advice and best regards,
Sabine
*Sabine Heider
**SAP AG

*Pflichtangaben/Mandatory Disclosure Statements:
_http://www.sap.com/company/legal/impressum.epx_


--------------------------------------------------------------
----------
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev


Back to the top