[eclipselink-dev] WDF tests on server

["Goerler, Adrian" <adrian.goerler@xxxxxxx>]

Hi,

 

https://bugs.eclipse.org/bugs/show_bug.cgi?id=301295

 

Initial version of server-testing support for the WDF tests checked in.

 

Retested by Sabine and reviewed by Kevin.

 

So far it has been tested on NetWeaver and JBoss only. From my point of view, the build/test execution in Java SE should not be affected. But I don’t know the script that are executing the regression tests. So please be alert.

 

-Adrian

 

 

Von: Kevin Yuan [mailto:kevin.yuan@xxxxxxxxxx]
Gesendet: Mittwoch, 7. April 2010 15:44
An: Goerler, Adrian
Cc: Huyen H Nguyen; Krogh Peter W; Tom Ware
Betreff: Re: AW: WDF tests on server

 

Hi Adrian,
First of all, I am very sorry that I reply you too late since some errand have to run in my family yesterday. I have looked through all your changes, but haven't run on JBoss yet since you have lots of changes (I met some compile error after I manually made some changes based on your patch). But I think you can check in first if all WDF tests work fine on JAVASE (out of container) with your patch. So far I only have the following suggestions with your changes:

- Add "server-test" target explanation in the beginning of \trunk\jpa\eclipselink.jpa.wdf.test\build.xml, just like other targets, e.g. "test";
- It's better to pass the dynamic values for "transaction-type" and "data-source-type" (current values are hard code),  in trunk\jpa\eclipselink.jpa.wdf.test\resource\eclipselink-wdf-jpa1-model\persistence.xml;
- Some new classes for testing framework need to add copyright headers.

After you check in, it will be easy to run on JBoss and other application servers, probably we need to give extra enhancement in order to run all WDF tests on servers automatically, just like existing other jpa testing.

Thanks,
Kevin

Goerler, Adrian wrote:

Hi Kevin,

 

I hope you’ll get well soon and your sickness won’t spoil your holidays.

 

So far, I have tested on JBoss and NetWeaver only.

 

I have not tested yet on WebLogic or WAS. (Actually, I don’t even have these servers at hand).

 

There certainly will be some changes required in the respective <server>.properties files. A new property

 

server.testrunner.wdf=JavaEE/servertest/REMOTE/ServerTestRunnerImpl/org.eclipse.persistence.testing.framework.wdf.server.ServerTestRunner

 

has to be specified server-specifically.

 

Also I had some trouble with the packaging of the testserver.ear, I am deploying:

 

For NetWeaver, I had to package the jpa-model jar file at the root of the EAR, For JBoss, it needed to go into a lib folder.

 

Maybe, it would be better if you’d review the changes on JBosss firstly (provided you’d have a JBoss running).

 

In any case thanks and best regards,

 

Adrian

 

Adrian Görler
SAP AG

Pflichtangaben/Mandatory Disclosure Statements: http://www.sap.com/company/legal/impressum.epx

 

Von: Kevin Yuan [mailto:kevin.yuan@xxxxxxxxxx]
Gesendet: Donnerstag, 1. April 2010 17:25
An: Goerler, Adrian
Betreff: Re: WDF tests on server

 

Hi Adrian,

Thanks for your effort, unfortunately I am sick today, and wil be back to work next Tuesday. I will try to run WDF tests on WebLogic server and WAS, and will let you know ASAP.

Sorry about that.

Best Regards,

Kevin

On Apr 1, 2010, at 10:09 AM, "Goerler, Adrian" <adrian.goerler@xxxxxxx> wrote:

Hi Kevin,

 

I’ve prepared a first version of the server test integration for the WDF tests (https://bugs.eclipse.org/bugs/show_bug.cgi?id=301295).

 

I’ve tested it on JBoss 5.1 and NetWeaver 7.3.

 

Could you please have a look? Any feedback is welcome.

 

Regards, Adrian