I just did experimented again the problem of missing
debugging information while debugging trunk of 1.1.x.
For example, we have this in
..\br1.1.0\trunk\foundation\org.eclipse.persistence.oracle\build.properties
->
# Edit this property to "true" to enable debug
attributes like lines, variables and source-filename
javac.debug=true
javac.debuglevel=lines,source
So “variables” is still missing. We could be
using a batch editor fixing all the build.properties or rely more on some kind
of hierarchic default.
Please fix systematically.
-----Original Message-----
From: Eric Gwin [mailto:eric.gwin@xxxxxxxxxx]
Sent: Wednesday, May 13, 2009 10:12 PM
To: Sebastien Tardif
Subject: Re: FW: [eclipselink-dev] Please release all Jars with full classinformation
so that debugging is seamless
NP. I thought I'd already done it. Since it hadn't been
checked in, I
did it before I forgot about it.
Unfortunately, it's unlikely to make it into 1.1.1,
though 1.1.2 and the
2.0.0 stream are fixed to use it.
and yes, all the "official" builds should have
vars info. As to your
other question: it isn't a matter of why we would or
wouldn't want
"vars" in other builds. It was simply a matter
time - 5 min to change 1
line and check it in vs 15 -20 min searching for and
replacing all the
defaults in the bundle build files too. I am working on
other deadlines
right now, but could spare the 5 min. I commented on the
other build
files so I'd remember to go back and fix them up as well
at a later date.
HTH
-Eric
Sebastien Tardif wrote:
>
> Thanks for the fast adaptation.
>
> I don’t understand why depending of where we
run the build we may not
> want “vars”.
>
> _ _
>
> Does the change is enough to expect official
released Jars will be
> build using “vars”?
>
> Revision: 4178
>
> Author: egwin
>
> Date: 4:07:10 PM, Wednesday, May 13, 2009
>
> Message:
>
> change default of full build to full debug info
(lines,vars,source)
> defaults in bundles unchanged, but overridden if run
from main build.
>
> ----
>
> Modified : /branches/1.1.0/trunk/build.properties
>
>
------------------------------------------------------------------------
>
> *From:* eclipselink-dev-bounces@xxxxxxxxxxx
> [mailto:eclipselink-dev-bounces@xxxxxxxxxxx] *On
Behalf Of *Sebastien
> Tardif
> *Sent:* Wednesday, May 13, 2009 9:53 AM
> *To:* Dev mailing list for Eclipse Persistence
Services
> *Subject:* [eclipselink-dev] Please release all Jars
with full
> classinformation so that debugging is seamless
>
> Please always release all Jars with full class
information so that
> debugging is seamless.
>
> It seems many other third parties including stuff
from Sun are
> providing full debugging information. In Java, that
seems to be
> standard since the cost is negligible.
>
> However, with EclipseLink/TopLink it seems
it’s popular to remove
> information that is unlikely to have no significant
performance impact
> on memory and CPU like:
>
> - add variable attributes to generated class files
>
> - add line number attributes to generated class files
>
> - add source file name to generated class file
>
> Current setting in
>
trunk\jpa\org.eclipse.persistence.jpa\build.properties is
> javac.debuglevel=lines,source
>
> Missing setting is “vars”. The available
settings are listed here:
> http://ant.apache.org/manual/CoreTasks/javac.html
>
> Maven default is lines,vars,source, see
>
http://maven.apache.org/maven-1.x/plugins/java/properties.html
>