Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipselink-dev] Changes to core.test... 
Hiya,

I think I found the issue, or at least a big contributor.

I notice that most of my generated paths are mixed "\" "/" and relative
I wondered if it could be causing an issue, since I know my SRGs work if I use my ${user.home}/build.properties which defined "extensions.depend.dir=C:/__external.lib", but I discovered they weren't when letting the scripts run by default (I'd have sworn they did work before).
What I found is disconserting. Basically, the following in my ${user.home}/build.properties works 
extensions.depend.dir=C:/extension.lib.external
this doesn't:
extensions.depend.dir=C:\extension.lib.external
I'm going to need to find a way to generate only "/" paths from an OS that reports "\". Probably due to restrictions in junit/java
In the meantime, setting up an override file should take care of any issues in this regard 

-Eric

Gordon Yorke wrote:

Eric,
That can not be true. I have never had custom properties for the extension.lib.external location and I am not the only one experiencing problems with the new updates. I've checked with peter and he stated his extension.lib.external directory in the same location as mine ../../.. above trunk. I always invoke from within the trunk directory and I imagine most people do.
I do not see any need to roll back your changes but the location of extension.lib.external should remain the same or anyone (including community users) are going to have troubles after this. 
--Gordon


Eric Gwin wrote:

Gordon,
The default for extension.lib.external has always been one dir above trunk. Both configs below accomplish exactly what you are talking about, with the exception that the latter is one level less deep. With the following config the extension dir is shared between views: 
C:\extension.lib.external
C:\trunk
C:\1.2
C:\1.1.0
However, it is admittedly less tidy.
The change I made forced the same build.properties file to load no matter where the build was invoked. Previously, the trunk/build.properties file would get loaded by core.test if called (and run) from trunk, but the core.test/build.properties file would be loaded if run from core.test. I changed it such that the core.test/build.properties would always be loaded when running core.test/build.xml (which appears to have been the assumed behavior), and added code to determine how it was being run and configure the paths accordingly.
I have commented out the <fail> tests, it allowed Peter to compile. If you are still having issues I'll revert and we can open up the discussion of assumed defaults again after M9. 

-Eric

Gordon Yorke wrote:
Yes, that is how it was setup in the build scripts originally. Why would I want to copy extension.lib.external into every svn view? I want one directory above my views that all views can use. 

--Gordon

Eric Gwin wrote:

Do you mean to tell me you guys are setup like:

C:\
|---extension.lib.external
|---projects
          |--- trunk
                   |--- foundation
                   |           |--- eclipselink.core.test
                   | --- jpa

rather than:

C:\
|---extension.lib.external
|--- trunk
        |--- foundation
        |           |--- eclipselink.core.test
        | --- jpa

?

QA is setup using the latter.
you can define extensions.lib.external in a ${user.home}/build.properties and it will override the defaults in the build. 

-Eric


Gordon Yorke wrote:

extension.lib.external\junit.jar
I think the problem is in where the new build scripts are looking for extension.lib.external. Everyone is currently setup to have that directory at "*/trunk/../../ not in trunk. 

<condition property="core_test.2.base.dir" value="../.." else="..">
<property name="extensions.depend.dir" value="../${core_test.2.base.dir}/extension.lib.external"/> 

--Gordon


Eric Gwin wrote:
Where is your junit.jar? I'm fixing the error message - it was wrong. 

-Eric


Gordon Yorke wrote:

I am getting the following error when I attempt to build trunk:
BUILD FAILED
D:\development\eclipselink\eclipselink-trunk\trunk\build.xml:275: The following 
error occurred while executing this line:
D:\development\eclipselink\eclipselink-trunk\trunk\foundation\eclipselink.core.t 
est\build.xml:207: Cannot find junit: '${junit.jar}'.

Total time: 2 minutes 7 seconds
D:\development\eclipselink\eclipselink-trunk\trunk>
"
This happens because the property junit.jar.exists has not been set. what part of my environment needs to be updated? 
--Gordon

Eric Gwin wrote:

Hi,
I just checked in an initial pass at reorganizing the core.test build on trunk (2.0.0). The build was successful with several test configurations, and passed the SRG. However, let me know if you encounter any problems.
I will be incrementally checking in each test build as I complete the migration to adopt: - the current build standards (original reorg was never done on the tests) - detect 'product' to use for testing: eclipselink.jar, bundles or 'classes' dirs - in that order. - improve performance by isolating initialization and conditionals in an init target
The second phase of this reorg will focus on creating generic testing artifacts to streamline the test process and remove redundant building. 

Thanks.

-Eric
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

Back to the top