Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipselink-dev] bug-248780.patch

There seems to be no need to cache emf inside of CacheImpl - ServerSession is all that required?
The only usage for emf inside CacheImpl would be to check whether the factory is still open - and throw exception in each method otherwise
Also getCache method should verify whether the factory isOpen - and fail if it's closed
----- Original Message -----
Sent: Wednesday, December 03, 2008 11:34 AM
Subject: Re: [eclipselink-dev] bug-248780.patch - createPKVector() -> no need to create local variables, just use method parameters.  Defining local variables could introduce errors and looks cluttered. -> make reference to cacheImpl 'protected'.  This is an EclipseLink coding pattern.

Otherwise this looks great.

Darani Yallapragada wrote:
Hello :

Fix for Bug#248780 is attached as "bug-248780.patch" file. Please do review this file .

Thank You


_______________________________________________ eclipselink-dev mailing list eclipselink-dev@xxxxxxxxxxx

eclipselink-dev mailing list

Back to the top