| [eclipselink-dev] Fix for bug 249500 - Daylight savings time is not printed in native SQL run against Oracle 9i and above |
|
The following fix has been checked in, and was previously reviewed. Bug 249500 - Daylight savings time is not printed in native SQL run against Oracle 9i and above https://bugs.eclipse.org/bugs/show_bug.cgi?id=249500 (a patch file has been uploaded to this bug) Foundation changes: - Added TIMESTAMPHelper.shouldAppendDaylightTime() method to return true if a passed Calendar represents Timestamp and TimeZone data which is currently within daylight savings time (DST) - Modified Oracle9Platform.appendCalendar() and Oracle9Platform.printCalendar() to append a 'TZD' element and short timezone DST information within the generated SQL if the call to TIMESTAMPHelper.shouldAppendDaylightTime() returns true Testing changes: - Added regression test CalendarDaylightSavingsTest to OracleTIMESTAMPTypeTestModel to test that generated SQL is correct for a variety of timezones and dates, including timezones that have never used DST and timezones that no longer use DST - Refactored OracleTIMESTAMPTypeTestModel.getTIMESTAMPUsingNativeSQLTestSuite() specifically to use dates +/- 10 years in the future/past instead of +/- 100 - Typographical error fixes Code review: Not required (previously reviewed by James Sutherland) Testing: LRG Oracle tests --
 David Minsky | Senior Member of Technical Staff | (613) 288-4605 Oracle Server Technologies | Sustaining Engineering 45 O'Connor Street, Suite 400, Ottawa, Ontario, Canada K1P 1A4 |