Re: [eclipselink-dev] Upgrade to Junit4.

[Les Davis <les.davis@xxxxxxxxxx>]

Eric,

I have completed and checked in the work in the MW tests for JUnit 4. 

Neil Hauge wrote:
> Eric,
>
> I am aware that we need to make these changes, I was more wondering 
> what the overall schedule for the migration would be.  We should have 
> this work completed by tomorrow, unless there are other unforeseen 
> issues with the migration.
>
> Neil
>
> Eric Gwin wrote:
> > Neil,
> >
> > I was just was pinged by Tom, who says you were wondering if I was 
> > waiting on anything from you regarding JUnit4. Basically, JUnit 
> > cannot be upgraded unless MW Tests compile and can run with  the new 
> > version.  So my  reply would be,  when can you have this work done?
> >
> > From the minimal response, it seems there is no resistance to 
> > upgrading, nor any specific preference for version. Therefore, I'd 
> > like to begin to use JUnit 4.4 (latest) in the build as soon as 
> > possible.
> >
> > Thanks.
> >
> > -Eric
> >
> > Neil Hauge wrote:
> > > The Workbench test related issues with the junit.swingui references 
> > > can be resolved by removing the main methods from our current 
> > > tests.  The main methods were written before integrated JUnit UI's 
> > > were bundled in IDE's.  So at this point I would consider the main 
> > > methods obsolete.
> > >
> > > Removing these methods should be a small work effort. Neil
> > >
> > > Eric Gwin wrote:
> > > > Edwin/Gordon,
> > > >
> > > > That is good to hear, the issue may not be as pervasive as it 
> > > > appeared. Perhaps the rework necessary is only in the MW test area:
> > > >
> > > >    [javac] Compiling 120 source files to 
> > > > C:\EclipseLinkTrunk\utils\eclipselink.utils.workbench.test\utility\classes 
> > > >
> > > >    [javac] 
> > > > C:\EclipseLinkTrunk\utils\eclipselink.utils.workbench.test\utility\source\org\eclipse\persistence\tools\workbench\test\utility\AllUtilityTests.java:26: 
> > > > package junit.swingui does not exist
> > > >    [javac] import junit.swingui.TestRunner;
> > > >    [javac]                      ^
> > > >
> > > > The above is the first compile error found. followed my hundreds 
> > > > more (each of the mwtest libraries). Though most are cascade 
> > > > failures, there may be additional legitimate errors as well.
> > > >
> > > > JUnit 4 has a different package structure (or rather additional 
> > > > package trees), though it sounds like much of it may be backward 
> > > > compatible.
> > > > -Eric
> > > >
> > > > EDWIN.TANG@xxxxxxxxxx wrote:
> > > > > Hi Gordon,
> > > > >
> > > > > The nightly testing has been using Junit4(Version 4.3.1) for 
> > > > > building and testing sine the beginning. There are no problem at 
> > > > > all. I don't think Version 4.4 would make any difference. I can 
> > > > > try this version out with tonight's run.
> > > > > Thanks,
> > > > > Edwin
> > > > >
> > > > > -----Original Message-----
> > > > > From: GORDON.YORKE@xxxxxxxxxx Sent: July 28, 2008 8:46 AM
> > > > > To: Dev mailing list for Eclipse Persistence Services
> > > > > Subject: Re: [eclipselink-dev] Upgrade to Junit4.
> > > > >
> > > > >
> > > > > What sort of testing rework?
> > > > > --Gordon
> > > > >
> > > > > Eric Gwin wrote:
> > > > >  
> > > > > > Hi,
> > > > > >
> > > > > > I'm working on integrating DBWS into the build system, it is 
> > > > > > using JUnit4 rather than JUnit3.
> > > > > >
> > > > > > Since we can only use once version of JUnit, I could ask that 
> > > > > > Mike rework his tests for JUnit3. However, I understand that 
> > > > > > Ganymede ships with JUnit4, and that JUnit3 is in End-of-Life. So 
> > > > > > we should probably All upgrade to JUnit4.
> > > > > >
> > > > > > With that in mind, I downloaded JUnit 4.4 last week and ran some 
> > > > > > tests. There will be test rework necessary with the upgrade.
> > > > > >
> > > > > > Before I go to the webmaster and ask permission to check in a 
> > > > > > version of JUnit4 so we can start to migrate I want to put it to 
> > > > > > you: Is there any reason we should not start migrating to JUnit4 
> > > > > > at this time?
> > > > > >
> > > > > > If not, Is there any reason we should not upgrade to the latest 
> > > > > > version of JUnit4?
> > > > > > If so, What version would would you recommend?
> > > > > >
> > > > > > Thanks.
> > > > > >
> > > > > > -Eric
> > > > > > _______________________________________________
> > > > > > eclipselink-dev mailing list
> > > > > > eclipselink-dev@xxxxxxxxxxx
> > > > > > https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
> > > > > >     
> > > > > _______________________________________________
> > > > > eclipselink-dev mailing list
> > > > > eclipselink-dev@xxxxxxxxxxx
> > > > > https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
> > > > > _______________________________________________
> > > > > eclipselink-dev mailing list
> > > > > eclipselink-dev@xxxxxxxxxxx
> > > > > https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
> > > > >
> > > > >   
> > > > _______________________________________________
> > > > eclipselink-dev mailing list
> > > > eclipselink-dev@xxxxxxxxxxx
> > > > https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
> > >
> > > _______________________________________________
> > > eclipselink-dev mailing list
> > > eclipselink-dev@xxxxxxxxxxx
> > > https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
>
> _______________________________________________
> eclipselink-dev mailing list
> eclipselink-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/eclipselink-dev