Comments:
-
build.xml
-- deletes
jaxp.properties file, what if the jre had one to begin with?
It will give a warning if not find this file.
-- includes,
doesn't ** include all the files listed? Those files
come from fundation famework, and compile failed without those files. By the
way, those file should add next <javac> element, ie, during compile
fundation framework, I have changed this in the new patch.
-- target
server-test-sessionbean, the persistence unit params are mixed with
fieldaccess Thx, and already changed.
<!--[if
!supportEmptyParas]--> <!--[endif]-->
Cool that all tests
pass, seems too easy :).
<!--[if
!supportEmptyParas]--> <!--[endif]-->
<!--[if
!supportEmptyParas]--> <!--[endif]-->
-----Original
Message-----
From: EDWIN.TANG@xxxxxxxxxx
Sent: Wednesday, July 30, 2008 11:31
AM
To: JAMES.SUTHERLAND@xxxxxxxxxx;
KEVIN.YUAN@xxxxxxxxxx
Cc: PRABAHARAN.VIJAYARATNAM@xxxxxxxxxx;
YIPING.ZHAO@xxxxxxxxxx; HUYEN.H.NGUYEN@xxxxxxxxxx
Subject: RE: [eclipselink-dev] Proposed
patch for bug 242289 - All Existing JPA Tests Need to Migrate Running on
Application Servers
<!--[if
!supportEmptyParas]--> <!--[endif]-->
Hi
James,
Could
you review the patch when you have a chance?
Thanks,
Edwin
-----Original
Message-----
From: KEVIN.YUAN@xxxxxxxxxx
Sent: July 30, 2008 11:23
AM
To: Dev mailing list for
Eclipse Persistence Services
Cc: PRABAHARAN.VIJAYARATNAM@xxxxxxxxxx;
YIPING.ZHAO@xxxxxxxxxx; HUYEN.H.NGUYEN@xxxxxxxxxx; EDWIN.TANG@xxxxxxxxxx
Subject: [eclipselink-dev] Proposed
patch for bug 242289 - All Existing JPA Tests Need to Migrate Running on
Application Servers
A
patch for the bug is available for review: https://bugs.eclipse.org/bugs/show_bug.cgi?id=242289
Change Summary:
- Modify trunk/jpa/eclipselink.jpa.test/build.xml
in order to share all descriptor files among all server test suites just
pass persistence-unit-name and
ejb-jar name within
application.xml.
- Add two targets for datatypes and datetime JPA junit
tests running on server.
- Modify test suite in order to run them on both
inside and outside Container, already verified on both J2SE and WebLogic ,
all tests passed.
- Add ejb-jar.xml,
application.xml, application-client.xml, persistence.xml under
trunk/jpa/eclipselink.jpa.test/resource/server
dir, and add persistence.xml
under trunk/jpa/eclipselink.jpa.test/resource/jboss
dir only for JBoss
use.
