RE: [eclipselink-dev] Proposed patch for bug 240993 - Need to Add Suppor

[EDWIN.TANG@xxxxxxxxxx]

Hi Kevin,

 

In general, the patch looks fine. A few comments:

 

1. In jboss.xml, this line can be removed. test.properties is already loaded in jpa/eclipselink.jpa.test/build.xml.
    <property file="./test.properties"/>

 

2. In jboss.xml, is this line required on unix/linux? On Windows, does it cause any problem or just be ignored?
        <chmod dir="${jboss.server}/deploy" perm="ugo+w" includes="*.xml"/>
3. Please clean up the heads of trunk/jpa/eclipselink.jpa.test/resource/jboss/${db.name}-ds.xml

 

Thanks,

Edwin

 

-----Original Message-----
From: KEVIN.YUAN@xxxxxxxxxx
Sent: July 18, 2008 1:21 PM
To: Eclipselink-Dev (E-mail)
Cc: EDWIN.TANG@xxxxxxxxxx; HUYEN.H.NGUYEN@xxxxxxxxxx; PRABAHARAN.VIJAYARATNAM@xxxxxxxxxx; YIPING.ZHAO@xxxxxxxxxx
Subject: [eclipselink-dev] Proposed patch for bug 240993 - Need to Add Support for Running JPA Tests on JBoss

A patch for the bug is available for review: https://bugs.eclipse.org/bugs/show_bug.cgi?id=240993

Change Summary:
- Add jboss.properties and jboss.xml under trunk\jpa\eclipselink.jpa.test
- Add persistence.xml for each test suite under trunk\jpa\eclipselink.jpa.test\resource\${MODEL_NAME}\server\jboss
- Add ${db.name}-ds.xml for jboss datasource create under trunk\jpa\eclipselink.jpa.test\resource\jboss
- Modify trunk\jpa\eclipselink.jpa.test\build.xml for the "server-build-ejb-jar" target during copy persistence.xml (jboss need to use its own persistence.xml)