[eclipselink-dev] fix for 221231: core: wrong/default JDBC Driver return

["Michael O'Brien" <michael.obrien@xxxxxxxxxx>]

Everyone,

    The following eclipselink.foundation change has been checked in.

 

    https://bugs.eclipse.org/bugs/show_bug.cgi?id=221231

 

    Details:

 

A wrong driver for a DB will not throw an SQLException, it will return a null connection without an exception by design.  Our DatabaseSessionImpl.loginAndDetectDatasource() is not handling this null - it expects an SQLE which would be thrown for all other db errors such as user/pass is wrong.
Result is that the first DriverManager connect fails with an SQLException in a warning - normal, but the 2nd sql.Driver.connect() call does not fail because it returns null - it later fails with a NPE when a conn.getMetaData() call is attempted.  The user can infer the source of the NPE by looking at the DriverManager warning.

    Code Reviewed by:

        Gordon

 

    thank you

    /michael