Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse.org-committers] -EXT- Do you have tips to update external contributions with Gitlab ?

Hello,

I'm not sure about gitlab, but in GitHub there is an option (selected by default) when opening a PR to allow committers to push changes to your branch. If that's enabled, then committers can use any of the usual tools to modify the PR branch. But otherwise, you generally can't update someone else's fork. If the author is unresponsive, and the contribution is valuable, then I believe it's generally ok to pull their branch (which must be public in order to open a PR), push it somewhere you control, and open a new PR, as long as you keep the original author attribution.

Thanks,

Emilio Lahr-Vivaz
General Atomics, CCRi

From: eclipse.org-committers <eclipse.org-committers-bounces@xxxxxxxxxxx> on behalf of LORENZO Vincent via eclipse.org-committers <eclipse.org-committers@xxxxxxxxxxx>
Sent: Thursday, January 23, 2025 4:57 AM
To: Eclipse Committers general discussion <eclipse.org-committers@xxxxxxxxxxx>
Cc: LORENZO Vincent <vincent.lorenzo@xxxxxx>
Subject: -EXT-[eclipse.org-committers] Do you have tips to update external contributions with Gitlab ?
 

WARNING:  This message is from an external source.  Evaluate the message carefully BEFORE clicking on links or opening attachments.

Dear Committers,

                I would like to know how you proceed on your project to fix/update yourself a merge requests received from a fork of your project.

                In the Papyrus-Web project, on the git, https://gitlab.eclipse.org/eclipse/papyrus/org.eclipse.papyrus-web, we receive MergeRequests from fork looking like this https://gitlab.eclipse.org/USERGIT/org.eclipse.papyrus-web/-/tree/A_BRANCH .

                Please, do you know if it exists an easy way to modify/amend the contents of the MergeRequest ? On my side I didn’t find answer on the web and ChatGPT advice me to update the fork to update the MR…

                I don’t want to have to clone the fork (in addition, it could be private I think) , then to update it to update the MR.

                I don’t want to have to refuse the MR for minor things that I can solve by myself. The basic usecase is a trivial rebase, that gitlab is not able to do itself…

                And I would find stupid to have to create a new MR and to abandon the initial contribution…

 

                I assume the problem would be the same on GitHub, right ?

 

Thanks for reading me, have a nice day.

Regards,

--

Vincent LORENZO

 


Back to the top