Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse-pmc] Allow Bug reference in commit footer?

I think in this rare case we could simply require to manually add the link to Bugzilla.

Daniel Megert <daniel_megert@xxxxxxxxxx> schrieb am So., 17. Mai 2020, 15:58:
We had issues in the past where two bugs were mentioned in the commit message. So, if above the footer another bug is referenced, it might pick the wrong one. I admit this might be a rare case, but it did happen.

Dani



From:        Lars Vogel <lars.vogel@xxxxxxxxxxx>
To:        eclipse-pmc@xxxxxxxxxxx
Date:        17.05.2020 15:46
Subject:        [EXTERNAL] Re: [eclipse-pmc] Allow Bug reference in commit footer?
Sent by:        eclipse-pmc-bounces@xxxxxxxxxxx




Not sure what youean. Auto-linking works fine if you put the bug into the footer. EGit and other projects use this style.

Daniel Megert <daniel_megert@xxxxxxxxxx> schrieb am So., 17. Mai 2020, 14:09:
The auto-link to bugzilla could be a problem. AFAIK it just takes the first number in the comment to detect the bugzilla entry.

Dani




From:        
Lars Vogel <lars.vogel@xxxxxxxxxxx>
To:        
eclipse-pmc@xxxxxxxxxxx
Date:        
17.05.2020 12:42
Subject:        
[EXTERNAL] [eclipse-pmc] Allow Bug reference in commit footer?
Sent by:        
eclipse-pmc-bounces@xxxxxxxxxxx




Hi,

I suggest that we (optionally) allow for commit messages to use the
"EGit" style in which the Bug number is added as meta-data at the end.

Example:
-------------
Commit message header

Description

Bug: xxxxxxx
Change-Id: Ica9dd21a9bf5fec0645f49fd7ffdc7f6cfff364a
Signed-off-by: xxx
--------------

This would IMHO read better in the history view and is more consistent
with the cleanup commits, which also have no bug reference in the
header message.

PMC members, WDYT?

Best regards, Lars

--
Eclipse Platform project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email:
lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com
_______________________________________________
eclipse-pmc mailing list

eclipse-pmc@xxxxxxxxxxx
To unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/eclipse-pmc




_______________________________________________
eclipse-pmc mailing list

eclipse-pmc@xxxxxxxxxxx
To unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/eclipse-pmc_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/eclipse-pmc



_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/eclipse-pmc

Back to the top