[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse-pmc] Gerrit submit strategies proposal

+1 too.
In my development projects here at SAP we use Gerrit with "merge if necessary" without issue.
I assume that the platform.ui gerrit builds job do a rebase on master...

ïOn 02.10.19, 08:55, "eclipse-pmc-bounces@xxxxxxxxxxx on behalf of Karsten Thoms" <eclipse-pmc-bounces@xxxxxxxxxxx on behalf of karsten.thoms@xxxxxxxxx> wrote:

    Yes, PLEASE, it is PITA to rebase over and over again. Especially for long running builds as in platform-ui. This is wasting committers' time and frustrates contributors.
    
    +1
    
    > Am 01.10.2019 um 13:00 schrieb Lars Vogel <lars.vogel@xxxxxxxxxxx>:
    > 
    > +1 I don't think that the rebased changes are reviewed again and
    > again, committers just have to wait a long time to get a merge window
    > and that is demotivating.
    > 
    > Now that our committer and contributor community activity has hugely
    > increased, we should remove that demotivating approach.
    > 
    > On Tue, Oct 1, 2019 at 12:40 PM Aleksandar Kurtakov <akurtako@xxxxxxxxxx> wrote:
    >> 
    >> We are seeing an increating contributions and our gerrit verification jobs start to suffer due to our usage of "Fast forward only" strategy. Reality though is that no one rebases his change multiple times and wait for gerrit again just because another commit went in, I've tried and in platform.ui I gave up on 3rd rebase and just pushed it right after rebase. But even this generated one more totally useless gerrit build.
    >> So my proposal is to change our strategy to "Rebase if Necessary"  - I don't see any downside using it and multiple benefits - free a lot of time on our builders, reduce interruptions for contributors and so on.
    >> Let's discuss today on PMC call
    >> 
    >> Strategies explained: https://gerrit-review.googlesource.com/Documentation/concept-changes.html#submit-strategies
    >> 
    >> --
    >> Alexander Kurtakov
    >> Red Hat Eclipse Team
    >> _______________________________________________
    >> eclipse-pmc mailing list
    >> eclipse-pmc@xxxxxxxxxxx
    >> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
    >> https://www.eclipse.org/mailman/listinfo/eclipse-pmc
    > 
    > 
    > 
    > -- 
    > Eclipse Platform project co-lead
    > CEO vogella GmbH
    > 
    > Haindaalwisch 17a, 22395 Hamburg
    > Amtsgericht Hamburg: HRB 127058
    > GeschÃftsfÃhrer: Lars Vogel, Jennifer Nerlich de Vogel
    > USt-IdNr.: DE284122352
    > Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com
    > _______________________________________________
    > eclipse-pmc mailing list
    > eclipse-pmc@xxxxxxxxxxx
    > To change your delivery options, retrieve your password, or unsubscribe from this list, visit
    > https://www.eclipse.org/mailman/listinfo/eclipse-pmc
    
    _______________________________________________
    eclipse-pmc mailing list
    eclipse-pmc@xxxxxxxxxxx
    To change your delivery options, retrieve your password, or unsubscribe from this list, visit
    https://www.eclipse.org/mailman/listinfo/eclipse-pmc