[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse-pmc] Fw: [cross-project-issues-dev] SimRel 2019-09 RC2 crashes on Windows 10 on inline rename in the Project Explorer

Dear PMC

After testing a lot on two different machines and different JREs it turns out that this is really a critical bug. https://bugs.eclipse.org/bugs/show_bug.cgi?id=550857#c21contains the different scenarios. The really bad one is:

In Project Explorer 'F2' followed by in-line renaming and press Enter. Now switch focus after successful rename. Crash.

This means any Windows 10 user that tries to rename a file which supports inline rename will get a crash after focus change.

My team is currently looking at two possible fixes:
- Find a way (probably in SWT) to prevent the crash.
- Find a way to disable or remove the feature. The changes can't be simply reverted as new API was added.
I will get an update on this in in an hour or two and update here.

We might consider to ship 4.13 with the bug and warn users and then produce 4.13a. Another option is to respin but that will most likely delay the release. Keep in mind we do not yet have a fix.

Dani



From:        "Thomas Watson" <tjwatson@xxxxxxxxxx>
To:        eclipse-pmc@xxxxxxxxxxx
Date:        13.09.2019 17:16
Subject:        [EXTERNAL] Re: [eclipse-pmc] Fw: [cross-project-issues-dev] SimRel 2019-09 RC2 crashes on Windows 10 on inline rename in the Project Explorer
Sent by:        eclipse-pmc-bounces@xxxxxxxxxxx




I also am -1 on revert.  I second McQ's recommendations.

Tom

 
 
----- Original message -----
From: "Mike Wilson" <Mike_Wilson@xxxxxxxxxx>
Sent by: eclipse-pmc-bounces@xxxxxxxxxxx
To: eclipse-pmc@xxxxxxxxxxx
Cc:
Subject: [EXTERNAL] Re: [eclipse-pmc] Fw: [cross-project-issues-dev] SimRel 2019-09 RC2 crashes on Windows 10 on inline rename in the Project Explorer
Date: Fri, Sep 13, 2019 10:02 AM
 

Sure. For completeness, I'm also -1 on reverting the whole change. My recommendations are:
 
- Make sure the release notes explain the situation, and that there is an answered question for it on StackOverflow (and any other forums that make sense).
- Timebox a couple of hours to see if there is some safe+small patch that would be worth the risk.
- Do a postmortem to understand why this wasn't caught in testing. Do we have no devs using win10?
 
McQ.
----- Original message -----
From: "Daniel Megert" <daniel_megert@xxxxxxxxxx>
Sent by: eclipse-pmc-bounces@xxxxxxxxxxx
To: eclipse-pmc@xxxxxxxxxxx
Cc:
Subject: [EXTERNAL] Re: [eclipse-pmc] Fw: [cross-project-issues-dev] SimRel 2019-09 RC2 crashes on Windows 10 on inline rename in the Project Explorer
Date: Fri, Sep 13, 2019 10:48 AM

Someone would have to investigate and even a smaller change comes with a risk at this point.


Dani




From:        
"Mike Wilson" <Mike_Wilson@xxxxxxxxxx>
To:        
eclipse-pmc@xxxxxxxxxxx
Date:        
13.09.2019 16:13
Subject:        
[EXTERNAL] Re: [eclipse-pmc] Fw: [cross-project-issues-dev] SimRel 2019-09 RC2 crashes on Windows 10 on inline rename in the Project Explorer
Sent by:        
eclipse-pmc-bounces@xxxxxxxxxxx



Is it possible to create a smaller patch to disable the feature on win10, without reverting the code?

McQ.

----- Original message -----
From: "Daniel Megert" <daniel_megert@xxxxxxxxxx>
Sent by: eclipse-pmc-bounces@xxxxxxxxxxx
To: "eclipse-pmc@xxxxxxxxxxx" <eclipse-pmc@xxxxxxxxxxx>
Cc: "Cross project issues \(cross-project-issues-dev@xxxxxxxxxxx\)" <cross-project-issues-dev@xxxxxxxxxxx>
Subject: [EXTERNAL] [eclipse-pmc] Fw: [cross-project-issues-dev] SimRel 2019-09 RC2 crashes on Windows 10 on inline rename in the Project Explorer
Date: Fri, Sep 13, 2019 10:04 AM

Moving to Eclipse PMC.


The changes are not small and we're past RC2 and supposed to ship next week. I'm currently tending to not revert.


PMC members, please chime in.


Dani


----- Forwarded by Daniel Megert/Zurich/IBM on 13.09.2019 15:56 -----


From:        
Holger Voormann <eclipse@xxxxxxxxxxx>
To:        
Cross project issues <cross-project-issues-dev@xxxxxxxxxxx>
Date:        
13.09.2019 14:38
Subject:        
[EXTERNAL] [cross-project-issues-dev] SimRel 2019-09 RC2 crashes on Windows 10 on inline rename in the Project Explorer
Sent by:        
cross-project-issues-dev-bounces@xxxxxxxxxxx



Hi,

At least on my Windows 10 computer, the Java VM crashes (immediately or
after a delay) when using the new inline rename feature (F2) in the
Project Explorer. Changes of files that have not yet been saved will be
lost.

I've tested it on two more computers. On another Windows 7 computer with
the same Eclipse IDE and JRE it did not crash, but on another Windows 10
computer it did. The issue seems to occur on Windows 10 independent of
the CPU/GPU, of the Java VM and of the IDE package.

Therefore I suggest, as long as bug 550857 (
http://eclip.se/550857) is
not fixed, to revert inline renaming in the Project Explorer (bug 548877
-
http://eclip.se/548877).

Thanks,

Holger
_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev



_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://www.eclipse.org/mailman/listinfo/eclipse-pmc

_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://www.eclipse.org/mailman/listinfo/eclipse-pmc

 

_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://www.eclipse.org/mailman/listinfo/eclipse-pmc
 
 
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://www.eclipse.org/mailman/listinfo/eclipse-pmc
 
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/eclipse-pmc