Thanks Eric for bringing
this up!
I am +1 too with
the following small changes (in bold
blue):
"With respect
to GTK+3 themes: Adwaita
theme is guaranteed
to work. Eclipse SDK will run with other GTK+
3 themes, however
we cannot flag these as reference versions without significant community
support for testing and/or development of fixes. Bugsthat arereproducible onlywith themes other
than Adwaita will be given a lower priority (or may not be fixed at all),
compared to bugs which are reproducible on the target environments listed
above."
Hey Dani :),
I presume that
we add this to what we already say about the versions.
I will add that
to the 4.12. plan.
Dani
From:
Aleksandar
Kurtakov <akurtako@xxxxxxxxxx>
To:
eclipse-pmc@xxxxxxxxxxx
Date:
21.02.2019
17:59
Subject:
Re:
[eclipse-pmc] Fwd: SWT-GTK theme support
Sent
by: eclipse-pmc-bounces@xxxxxxxxxxx
On Thu, Feb 21, 2019 at 6:55 PM Mike
Wilson <Mike_Wilson@xxxxxxxxxx>
wrote:
> that we only support the default
GTK themes shipped with GTK (not a desktop
> environment), and that users
are more than welcome to use their own custom
> GTK theme at their own risk.
I certainly understand
why we would do this. The interaction between SWT's quite complex use of
GTK and the myriad of (varying quality) themes out there is not something
we're going to be able to fix. It's a shame, but I'm +1.
Here is my +1 too. I propose adding
to the project plan:
" With respect to GTK 3 themes:
the guaranteed to work theme is Adwaita. Eclipse SDK will run with other
GTK themes, however we cannot flag these as reference versions without
significant community support for testing and/or development of fixes.
Bugs only reproducible with themes other than Adwaita will be given a lower
priority (or may not be fixed at all), compared to bugs which are reproducible
on the target environments listed above."
McQ.
----- Original message
-----
From: Eric Williams <ericwill@xxxxxxxxxx>
Sent by: eclipse-pmc-bounces@xxxxxxxxxxx
To: Eclipse PMC <eclipse-pmc@xxxxxxxxxxx>
Cc:
Subject: [eclipse-pmc] Fwd: SWT-GTK theme support
Date: Thu, Feb 21, 2019 11:44 AM
Forwarding to the PMC list for discussion
-- see below.
-------- Forwarded Message --------
Subject: SWT-GTK theme support
Date: Thu, 21 Feb 2019 10:58:57 -0500
From: Eric Williams <ericwill@xxxxxxxxxx>
To: platform-dev@xxxxxxxxxxx
Hello,
I'd like to propose an addition to the SWT planning documents,
specifically the target environments section wrt. to GTK3.
Some background information:
On the Linux side of things we often encounter users running custom GTK
themes (i.e. themes not shipped with GTK itself) reporting issues
against SWT. These issues are not actual bugs in SWT but simply issues
with the user's theme.
SWT exposes bugs in GTK themes quite often because we support widgets of
all sizes, meaning themes that use padding/margin in odd places will
usually see visual glitches (as an example). Native GTK applications
usually don't expose such issues because they do not allow users to
resize widgets below the GTK minimum size, which is a nice luxury we
cannot offer due to API contracts.
For years the position has been that SWT-GTK will support the default
themes shipped with GTK itself. We *do* patch theme issues that SWT
exposes against the default themes, but they are pretty rare as the
default GTK themes are well supported.
Now, some users are very attached to their custom themes and would
prefer to maintain their own theme at their own cost. We have given
users the option to do so via an environment variable that allows for
injection of custom GTK CSS into SWT. Our only caveat here is that users
who choose to go down this road are on their own -- SWT developers will
not be fixing bugs in a user's custom GTK theme.
This is a problem unique to Linux due to the nature of theming in GTK.
Mac and Windows don't really have to deal with this, as by-and-large
they do not support themes other than the default.
My proposal:
We should add some comment in the platform plan target environments
section about GTK themes, namely: that we only support the default GTK
themes shipped with GTK (not a desktop environment), and that users are
more than welcome to use their own custom GTK theme at their own risk.
I
will also be happy to link to a wiki article (which I'll write very
soon) which explains all of this in detail and what avenues are
available to users who want to use custom GTK themes.
The reason I bring this up is that there is often quite a bit of back
and forth in Bugzilla about such topics, and having the position
explained in a planning document will save SWT developers quite some
time when this topic arises.
Thoughts?
--
Eric Williams
Software Engineer - Eclipse/SWT Team
Red Hat
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/eclipse-pmc
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/eclipse-pmc
--
Alexander Kurtakov
Red Hat Eclipse Team_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/eclipse-pmc
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/eclipse-pmc
