Re: [eclipse-pmc] PMC approval needed for patchhttps://git.eclipse.org/r

[Lars Vogel <lars.vogel@xxxxxxxxxxx>]

+1 to Danis and Alex suggestion. If the intention is to add tests for M7, I think we can leave this patch in to avoid the revert, revert the revert dance. 

@Lucas, are there plans to add tests?

On Tue, Mar 27, 2018 at 3:40 PM, Aleksandar Kurtakov <akurtako@xxxxxxxxxx> wrote:

On Tue, Mar 27, 2018 at 4:31 PM, Daniel Megert <daniel_megert@xxxxxxxxxx> wrote:

Hi Lucas

I looked at the patch and the bug report and could not find test cases or examples that test and verify the changes. So, unless being able to see that this actually works, I'm inclined to give a -1. Let's see what others think.

I think the patch is good and add important functionality. But I also fully agree with Dani that it must be accompanied with tests. So once there are such tests it has +1 from me.

 

Dani



From:        Lucas Bullen <lbullen@xxxxxxxxxx>
To:        eclipse-pmc@xxxxxxxxxxx
Date:        27.03.2018 15:13
Subject:        [eclipse-pmc] PMC approval needed for patch        https://git.eclipse.org/r/#/c/119994/
Sent by:        eclipse-pmc-bounces@eclipse.org

---

The patch https://git.eclipse.org/r/#/c/119994/adds support for an "enabledWhen" tag for all the generic editor extension points, allowing users of the editor to enable it's features only when a certain requirement is met. This fix is required to allow current implementers of the extensions who are currently using blanket enablement of features to better define when features should be enabled to avoid unwanted results and overlaps with other use cases.

The new additions to the schema are optional, so the addition of them does not effect any existing users, and is documented within their schema's, making its addition one with low risk.

The patch has already been merged due to my error and will be reverted if this request is denied, however is not currently reverted to avoid the confusion if this is accepted.

--

Lucas Bullen

Software Engineering Intern

Red Hat

90 Eglinton Ave E #502,

Toronto, ON M4P 2Y3

lbullen@xxxxxxxxxx   

_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_eclipse-2Dpmc&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=1WaJLgSovFaCb5Cp6teXj3L5Q_wS1J9BKYmlKL-cS8A&s=gTrW3A5QTPAtCSyH1bO-nLxKKSWiPegLx45ems08G8M&e=



_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/eclipse-pmc

--

Alexander Kurtakov

Red Hat Eclipse Team

_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc

--

Eclipse Platform project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com