[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [eclipse-pmc] PMC approval needed for patch https://git.eclipse.org/r/#/c/50300/ ?
|
> I completely agree with Ed and Andrey.
And by Ed, you mean Tom?
On Tue, Mar 20, 2018 at 10:43 AM, Daniel Megert
<daniel_megert@xxxxxxxxxx> wrote:
> I completely agree with Ed and Andrey.
>
> -1 from me.
>
> Dani
>
>
>
> From: "Andrey Loskutov" <loskutov@xxxxxx>
> To: eclipse-pmc@xxxxxxxxxxx
> Cc: eclipse-pmc@xxxxxxxxxxx
> Date: 20.03.2018 09:27
> Subject: Re: [eclipse-pmc] PMC approval needed for patch
> https://git.eclipse.org/r/#/c/50300/?
> Sent by: eclipse-pmc-bounces@xxxxxxxxxxx
> ________________________________
>
>
>
> I'm not a PMC team member, but looking on the change I fully agree with Tom.
> IMHO this is too big/too risky for M7, such kind of changes should be done
> much earlier to be able to catch and fix all possible side effects of API
> generification.
>
> Kind regards,
> Andrey Loskutov
>
> https://urldefense.proofpoint.com/v2/url?u=http-3A__google.com_-2BAndreyLoskutov&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=5Qa_Cayn48XyDjre4hVgZoTuV7DDTTSZLvh3qErKow8&s=DSXyAL4iE3FWbB5671uPzbdw2ZdfUMg5MsgobhBP1kU&e=
>
>
>> Gesendet: Dienstag, 20. März 2018 um 09:18 Uhr
>> Von: "Tom Schindl" <tom.schindl@xxxxxxxxxxxxxxx>
>> An: eclipse-pmc@xxxxxxxxxxx
>> Betreff: Re: [eclipse-pmc] PMC approval needed for patch
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__git.eclipse.org_r_-23_c_50300_&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=5Qa_Cayn48XyDjre4hVgZoTuV7DDTTSZLvh3qErKow8&s=QaUya4UPV4wDRXjI7_c3uGr4WVgB5724cM84DcSJgsE&e=?
>>
>> On 19.03.18 22:35, Lars Vogel wrote:
>> > +1 from my side (as I suggest to Conrad to ask the PMC for
>> > permission). I know Conrad and he has a very deep understanding of DB
>> > and I trust his judgment.
>> >
>> > Also, the API relevant change is minimal with only two (small) classes.
>>
>> Really? I count a whole lot of API changes because generics have been
>> added. When you generify an API you have ONLY one chance to get it
>> right, so this needs to be reviewed with special care.
>>
>> Having said that, I have no time to review this stuff.
>>
>> Tom
>> _______________________________________________
>> eclipse-pmc mailing list
>> eclipse-pmc@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe
>> from this list, visit
>>
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_eclipse-2Dpmc&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=5Qa_Cayn48XyDjre4hVgZoTuV7DDTTSZLvh3qErKow8&s=6Ayouyd2pItWGz_1M3PGcoXqDsINBvH6-XKt0EsPHbc&e=
>>
> _______________________________________________
> eclipse-pmc mailing list
> eclipse-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_eclipse-2Dpmc&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=5Qa_Cayn48XyDjre4hVgZoTuV7DDTTSZLvh3qErKow8&s=6Ayouyd2pItWGz_1M3PGcoXqDsINBvH6-XKt0EsPHbc&e=
>
>
>
>
> _______________________________________________
> eclipse-pmc mailing list
> eclipse-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
--
Eclipse Platform project co-lead
CEO vogella GmbH
Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com
