Re: [eclipse-pmc] PMC approval needed for patch https://git.eclipse.org/

[Tom Schindl <tom.schindl@xxxxxxxxxxxxxxx>]

One more note before you merge:
a) make sure EMF-Databinding still compiles
b) make sure EMF-Databinding (who IIRC is compiled against an older API
   - Helios) still works without getting recompiled

If you break EMF-Databinding you break the complete e4 tooling and most
likely a lot more.

Tom

On 20.03.18 09:18, Tom Schindl wrote:
> On 19.03.18 22:35, Lars Vogel wrote:
>> +1 from my side (as I suggest to Conrad to ask the PMC for
>> permission). I know Conrad and he has a very deep understanding of DB
>> and I trust his judgment.
>>
>> Also, the API relevant change is minimal with only two (small) classes.
> 
> Really? I count a whole lot of API changes because generics have been
> added. When you generify an API you have ONLY one chance to get it
> right, so this needs to be reviewed with special care.
> 
> Having said that, I have no time to review this stuff.
> 
> Tom
> _______________________________________________
> eclipse-pmc mailing list
> eclipse-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
>