Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse-pmc] Fw: Urgent: Critical Bug for RC4a
Hi,
 
Small correction: the problem was that menu items were leaked every time on *menu* open/close (for *both* global & context menus), so it is not just 44 byte leak.
 
The current regression seem to occur for e4 based contributions only, if the menu has a mix of "menu:DynamicMenuContribution" and "menu:HandledMenuItem" elements. If no "DynamicMenuContribution" contributons are there, the problem can't be reproduced.
 
Kind regards,
Andrey Loskutov

http://google.com/+AndreyLoskutov
 
 
Gesendet: Montag, 12. Juni 2017 um 12:06 Uhr
Von: "Martin Oberhuber" <mober.at+eclipse@xxxxxxxxx>
An: eclipse-pmc@xxxxxxxxxxx, "Daniel Megert" <daniel_megert@xxxxxxxxxx>
Betreff: Re: [eclipse-pmc] Fw: Urgent: Critical Bug for RC4a
+1 for reverting the attempted fix for for bug 354538 [1] for RC4a.

I have only read the bugzilla comments and not looked at the source, but
- Bug 354538 causes only a 44 byte leak on every WorkbenchWindow open/close (which happens rarely in my experience)
- Bug 354538 is known since 2011
- Earlier attempts fixing the issue have also caused regressions and have been reverted.

This fix isn't bulletproof yet, and the regression is severe.

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=354538


On 2017-06-12 11:13, Daniel Megert wrote:
> A critical issue (see bug 518036)

The link is wrong. Correct is https://bugs.eclipse.org/518036
.
----- Forwarded by Daniel Megert/Zurich/IBM on 12.06.2017 11:12 -----

From:        Daniel Megert/Zurich/IBM
To:        "eclipse-pmc@xxxxxxxxxxx" <eclipse-pmc@xxxxxxxxxxx>
Date:        12.06.2017 11:11
Subject:        Urgent: Critical Bug for RC4a


Dear PMC Colleagues

A critical issue (see bug 518036) was found, which causes duplication of menu entries when dynamic menu contributions are used. This regression got introduced with M6 to fix an old (4.1 / 2011) bug regarding leaks. While leaks are bad, menu duplication is a real show stopper. I therefore propose to fix this for RC4a together with the EMF update. The fix is to revert the leak fix. The revert can be done without conflicts.

I would like to have an answer today, so, that we can build RC4a asap.

Thanks,
Dani

 
 
  
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc

 

--
Martin Oberhuber | Software Architect, Project Lead & Consultant | Austria
_______________________________________________ eclipse-pmc mailing list eclipse-pmc@xxxxxxxxxxx To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/eclipse-pmc

Back to the top