Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse-pmc] Request to downport the CopyBuildIdToClipboardHandler changes of Bug 496319

+1 for the -1.

Dani



From:        Markus Keller/Zurich/IBM@IBMCH
To:        eclipse-pmc@xxxxxxxxxxx
Date:        25.08.2016 00:08
Subject:        Re: [eclipse-pmc] Request to downport the        CopyBuildIdToClipboardHandler        changes of Bug 496319
Sent by:        eclipse-pmc-bounces@xxxxxxxxxxx




-1, since this change hijacked an existing command and completely changed its behavior.

That not nice but acceptable for a new release, however it's exactly the kind of tweaks we should avoid in update releases.


Markus




From:        
Lars Vogel <lars.vogel@xxxxxxxxxxx>
To:        
eclipse-pmc@xxxxxxxxxxx
Date:        
2016-08-22 14:34
Subject:        
[eclipse-pmc] Request to downport the CopyBuildIdToClipboardHandler        changes of Bug 496319
Sent by:        
eclipse-pmc-bounces@xxxxxxxxxxx




Hi,

I request to downport to currently class CopyBuildIdToClipboardHandler.java

Here are the relevant changes:

https://git.eclipse.org/r/#/c/75658/9/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/commands/CopyBuildIdToClipboardHandler.java

And we also added the SWT version with this commit.

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0f0d8b4f63b7b569f675138bde11bc576f14d9b9

This will copy more detailed information from the current build into
the clipboard.

Example:

Neon: 4.6.0.I20160606-1100

Oxygen:

Eclipse SDK
Version: Oxygen (4.7)
Build id: N20160821-1959
OS: Linux, v.4.4.0-34-generic, x86_64 / gtk 3.18.9

Change is IMHO pretty minimal, harmless but very helpful for error analysis.

Best regards, Lars

--
Eclipse Platform UI and e4 project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web:
http://www.vogella.com
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/eclipse-pmc

_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc


Back to the top