Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[eclipse-pmc] Request PMC approval for bug 271757

GOALS/BENEFITS:

org.eclipse.compare.contentmergeviewer.TextMergeViewer.createSourceViewer
(Composite,
int) should return concrete SourceViewer instead of ISourceViewer
interface.
The ISourceViewer type is not enough for the MergeSourceViewer to work
properly, the MergeSourceViewer requires methods which are not part of the
ISourceViewer interface. The concrete class of SourceViewer is the optimal
return type.

ASSOCIATED BUGS:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=271757

RISKS:
The method is part API and has been
introduced in 3.5. The risk is low, especially given the fact that
the API is marked as "experimental" and using it should be consulted with
the
Workspace team. Impact is limited to JDT which is the only client of the
new
API so far.

PERFORMANCE IMPACT:
None.

--
Szymon Brandys



Back to the top