[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [eclipse-pmc] Request for limiting access scope for a method in TextMergeViewer
|
I'm not sure if there actually are people using the method. I would doubt
it, the method has been added recently (07-09-19 with bug
https://bugs.eclipse.org/bugs/show_bug.cgi?id=202944). The problem is that
if someone tries to use the method I believe he or she will get the
"discouraged access" warning. This is why the API Tooling shows us a yellow
card there.
Maybe I should ask people on cross-project-issues-dev list if they are ok
with that change.
Moreover, I would also go ahead and make the isNavigationPossible() private
too (as Markus suggested in the bug), even though it doesn't cause a leak.
--
Tomasz Zarna
Mike Wilson
<Mike_Wilson@ca.i
bm.com> To
Sent by: eclipse-pmc@xxxxxxxxxxx
eclipse-pmc-bounc cc
es@xxxxxxxxxxx Michael Valenta
<Michael_Valenta@xxxxxxxxxx>
Subject
2008-04-17 21:37 Re: [eclipse-pmc] Request for
limiting access scope for a method
in TextMergeViewer
Please respond to
eclipse-pmc@eclip
se.org
Is the reason why there are leaks because there *are* people using this API
(incorrectly) now?
McQ.
Tomasz Zarna
<TomaszZarna@pl.i
bm.com> To
Sent by: eclipse-pmc@xxxxxxxxxxx
eclipse-pmc-bounc cc
es@xxxxxxxxxxx Michael Valenta/Ottawa/IBM@IBMCA
Subject
[eclipse-pmc] Request for limiting
04/17/08 12:35 PM access scope for a method in
TextMergeViewer
Please respond to
eclipse-pmc@eclip
se.org
To fix the leak in the
org.eclipse.compare.contentmergeviewer.TextMergeViewer.isCurrentDiff(Diff)
method limiting its access scope from public to private is required. The
org.eclipse.compare.contentmergeviewer.TextMergeViewer class is API so I
need PMC persmission to proceed.
GOALS/BENEFITS:
No leak and no warning from the API Tooling.
CORRESPONDING BUG(S):
https://bugs.eclipse.org/bugs/show_bug.cgi?id=227585
RISKS:
No risk
PERFORMANCE IMPACTS:
No performance impact
--
Tomasz Zarna
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
