Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse-pmc] Add API methods to let working copy owner control the problem requestor used


GOALS/BENEFITS:
- As ICompilationUnit#becomeWorkingCopy(IProblemRequestor,
IProgressMonitor)
can be called several times, problems will not be reported on the given
requestor if it is different from the original one (see the method javadoc
comment).

To avoid this, we want to add a problem requestor on  WorkingCopyOwner and
use it by default while performing becomeWorkingCopy operation on an
ICompilationUnit.

If clients continue to specify their own problem requestor and use existing
becomeWorkingCopy API, problems will be reported on both requestors...

AFFECTED BUGS:
- https://bugs.eclipse.org/bugs/show_bug.cgi?id=175243

RISKS:
No known risks. Behavior is fully backward compatible and provide benefits
only if the new API is used.

PERFORMANCE IMPACTS:
- May have a small impact if clients intentionally use the current existing
API ICompilationUnit#becomeWorkingCopy(IProblemRequestor, IProgressMonitor)
*and* if they define a different problem requestor on the WorkingCopyOwner
using the new API WorkingCopyOwner#getProblemRequestor(ICompilationUnit).
However, as it would be considered a wrong usage of this new functionality,
there is a very low probability that this kind of mistake happens.



Cordialement/Regards,

Frédéric



Back to the top