Re: [eclipse-dev] Help reducing the open Gerrit queue

["Thomas Watson" <tjwatson@xxxxxxxxxx>]

Not to re-open the PMC decision (which I am not) ... I just want to advise on caution when reviewing for-each changes.  Recent performance analysis I've done shows that blindly applying for-each to ALL perfectly good-old for loops over arrays or ArrayList that do get(i) is not beneficial to performance if said for loop is a very hot spot in the code.  Admittedly the impact is small and in most cases negligible in actual performance measurements.

Tom
 

 

 

----- Original message -----
From: Lars Vogel <lars.vogel@xxxxxxxxxxx>
Sent by: eclipse-dev-bounces@xxxxxxxxxxx
To: "General development mailing list of the Eclipse project." <eclipse-dev@xxxxxxxxxxx>
Cc:
Subject: [EXTERNAL] [eclipse-dev] Help reducing the open Gerrit queue
Date: Wed, Dec 11, 2019 1:29 AM
 

Friends of Eclipse,

 

Please help reducing the open Gerrit queue. For example we have a ton of pending for-each Gerrits, would be nice to get these in early to be able to focus on more complex tasks.

 

Cleanup patches are desired as the PMC decided a while ago.

 

Best regards, Lars

_______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/eclipse-dev