[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse-dev] Does @noreference tag need PMC approval?

My point was only to make sure that this change was documented and 
properly referenced in the exclude list.
Having the bug id reported on pmc list or eclipse-dev list doesn't cost 
much and make sure that the exclude list contains only changes that are 
under control.

Olivier




Jeff McAffer <jeff@xxxxxxxxxxxxxxxxx> 
Sent by: eclipse-dev-bounces@xxxxxxxxxxx
2009-04-15 20:27
Please respond to
"General development mailing list of the Eclipse project." 
<eclipse-dev@xxxxxxxxxxx>


To
"General development mailing list of the Eclipse project." 
<eclipse-dev@xxxxxxxxxxx>
cc

Subject
Re: [eclipse-dev] Does @noreference tag need PMC approval?






I agree with Martin.  If something is already documented as not 
referencable then you are just cleaning that up.  People who get API 
warnings as a result are either free to ignore them as they were already 
doing or to remove their references (better to know now then later).

Jeff

Oberhuber, Martin wrote: 
Hi Tomasz,

my personal opinion would be that adding an API Tooling tag 
that just makes something machine-readable that had been 
in the Javadocs before (though expressed in plain English
language) is not an API change and therefore doesn't require 
approval.

I'd like to hear other opinions, though, and at any rate you
should inform others about your change to ensure that any 
automated scans for changes in API don't surprise people 
who are not aware of what you've been changing.

Cheers,
--
Martin Oberhuber, Senior Member of Technical Staff, Wind River
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
 
 

 
-----Original Message-----
From: eclipse-dev-bounces@xxxxxxxxxxx 
[mailto:eclipse-dev-bounces@xxxxxxxxxxx] On Behalf Of Tomasz Zarna
Sent: Mittwoch, 15. April 2009 11:49
To: eclipse-dev@xxxxxxxxxxx
Subject: [eclipse-dev] Does @noreference tag need PMC approval?


Regarding latest comment on
https://bugs.eclipse.org/bugs/show_bug.cgi?id=271343#c4:

Does adding tags like @noreference in a case where the javadoc clearly
states the method is for internal use only and cannot by 
called by clients
requires PMC approval?
I thought the change I made on the bug was not an API change, 
but Olivier
may be right here.

Have any of you had a similar problem? Do I need to ask for 
the approval?

Cheers,
--
Tomasz Zarna

_______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or 
unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-dev

 
_______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe 
from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-dev
  _______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe 
from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-dev