Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [eclipse-dev] Compiler warnings

My intention was simply to reduce the overhead of fixing these warnings
right before the release. I am not suggesting to set them as default values
in Eclipse, but rather each team could change its compiler settings. With
compiler settings per project, you don't need to change the global
settings.

Note that I didn't talk about unused arguments because of the issue you
described.

Olivier



                                                                                                                                                     
                      "genadyb"                                                                                                                      
                      <genadyb@xxxxxxxxx        To:       <eclipse-dev@xxxxxxxxxxx>                                                                  
                      .il>                      cc:                                                                                                  
                      Sent by:                  Subject:  RE: [eclipse-dev] Compiler warnings                                                        
                      eclipse-dev-admin@                                                                                                             
                      eclipse.org                                                                                                                    
                                                                                                                                                     
                                                                                                                                                     
                      04/22/03 10:57 AM                                                                                                              
                      Please respond to                                                                                                              
                      eclipse-dev                                                                                                                    
                                                                                                                                                     
                                                                                                                                                     




While I definetely agree that all these are bad things to have in your
software,
I would not like to see them as errors during development.
For example, I start writing a method and declare some local variable.
I save the file (I usually save the file every few keystrokes) -
and I get the warning/error about the unused local variable, while I was
just about to use it.
Also consider that unused arguments are common when your implementation
ignores some
of the arguments that are defined in an interface.

I suggest two different approaches:
1. Provide mechanism to shut down warnings for specific files (e.g., I
know that some files in my code uses some deprecated methods, and
I don't want to see them all in the tasks list). Today one of my
projects has >1000 different warnings, and I just don't see the new
ones.
I want to be able to tell eclipse "ok, I know about these, now complain
only about new problems".
2. Provide two sets of compiler flags: "strict" (for releases) and
"relaxed" (for everyday compiling).
For example, incrementat save can use the relaxed settings, and "rebuild
all" can use stric settings.

Genady

-----Original Message-----
From: eclipse-dev-admin@xxxxxxxxxxx
[mailto:eclipse-dev-admin@xxxxxxxxxxx] On Behalf Of Olivier Thomann
Sent: Tuesday, April 22, 2003 5:42 PM
To: eclipse-dev@xxxxxxxxxxx
Subject: [eclipse-dev] Compiler warnings


Hi,

I think it is time to change the settings of the compiler for everyone.
I
noticed new warnings in the latest nightly builds. They are mostly due
to
unused imports. It might be a godd thing that everyone is using the
following settings:
- unused import = ERROR
- unused locals = ERROR
- non static access to static member = ERROR
- assignment has no effect = ERROR
- Using a char array in string concatenation = ERROR

This might help to reduce the number of useless warnings. It took time
to
get rid of them prior to 2.1 release. So we might want to change the
settings immediately and that should prevent us from chasing them right
before the next release.

Any comment?

Olivier

_______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/eclipse-dev


_______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/eclipse-dev





Back to the top