Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ecf-dev] rest api change?

Hi Folks,

If this API change is not too disruptive, I would like to include it in ECF 3.6.0 (early March 2013). It would require clients that use this rest API to recompile, but it does add a significant amount of generality. It should have been done this way in the first place (my mistake), but I would rather correct it now.

Are there any objections (committers, contributors or consumers) to making this change for ECF 3.6.0?

Thanks,

Scott



 On 1/29/2013 2:56 PM, Scott Lewis wrote:
Hi Folks,

In order to address this bug:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=320175

I think it's going to be easiest to simply make a change in the org.eclipse.ecf.remoteservice.client.IRemoteResponseDeserializer API:

from

public Object deserializeResponse(String endpoint, IRemoteCall call, IRemoteCallable callable, Map responseHeaders, String responseBody) throws NotSerializableException;

to

public Object deserializeResponse(String endpoint, IRemoteCall call, IRemoteCallable callable, Map responseHeaders, byte[] responseBody) throws NotSerializableException;

(just change the responseBody from type String to type byte[]).

This change, however, would constitute a breaking API change, meaning that existing clients would need to recompile (at least).

Could those of you interested in this issue please comment on the bug? I would like to address this issue at some time, and now/ECF 3.6 would be a reasonable time, I think.

thanksinadvance,

Scott







_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev




Back to the top