Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ecf-dev] Gerrit

Hi Wim,

On 7/30/2012 1:56 PM, Wim Jongman wrote:
I have looked at the wiki and the previous discussion as pointed out by Scott and have this question: What problem is solved with Gerrit?

Assumption: Code reviews are desired/ least under some circumstances (e.g. contributions from non-committers)

If you grant the above assumption, I would say that Gerrit provides support for automating doing such code reviews (like any tool IMHO, it doesn't 'solve' the problem but rather 'improves/simplifies/supports' such a process).

It's not my intention/expectation that all commits/pushes to ECF would require a Gerrit review.  But there are occasions when having code reviews...and having support for doing so...would be useful IMHO (at least there are occasions when I would like to request that others review my contributions).




On Mon, Jul 30, 2012 at 7:44 PM, Scott Lewis <slewis@xxxxxxxxxxxxx> wrote:
Hi Markus,

On 7/29/2012 11:03 PM, Markus Alexander Kuppe wrote:
<stuff deleted>

+1 for Gerrit.

We would probably have to host our own instance or have the EF
webmasters integrate our Jenkins server with Gerrit for us (assuming we
want/need a review system <> build integration).

Hmmm.   I had been assuming that we would just follow the process for requesting Gerrit usage via the EF

...but I see what you mean about integrating with our Jenkins server.

Markus do you have any thoughts on how would you like to handle interacting with the EF admins about what's the best/right course here (e.g. hosting our own Gerrit vs. using EF Gerrit installation)?  I would like to see review system and build system integration (as Alex's video demonstrates)...but I'm not sure what this will take...and I certainly don't want to take on a whole lot of additional integration (and the inevitable maintenance)...if we don't have to.



ecf-dev mailing list

ecf-dev mailing list

Back to the top