[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [ecf-dev] Git commit messages
- From: Markus Alexander Kuppe <ecf-dev_eclipse.org@xxxxxxxxxxx>
- Date: Wed, 22 Jun 2011 10:52:55 +0200
- Delivered-to: email@example.com
- User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:22.214.171.124) Gecko/20110424 Lightning/1.0b2 Thunderbird/3.1.10
On 06/22/2011 10:48 AM, Alex Blewitt wrote:
> Basically, the convention is to have a single short line of text (less
> than 50 chars) which summarises the change, followed by a blank line,
> and then more text separated by blank lines (if there's more than one
> paragraph). The final section is for Key: Value pairs, which can include
> Signed-off-by and Change-Id as well as custom values, like Bug: 12345.
> Many of the changes in the current ECF log are one-liners, and often
> just reference a bugzilla item. This doesn't help someone who has cloned
> the repository knowing why the changes were made. Consider these two
> changes below (both for the same fix, bug 349078).
> Being able to do 'git log --oneline' and see descriptive changes is a
> lot more useful than being able to see a list of referenced bugs, as
> well as giving someone who has cloned (and may not be connected to the
> internet) the repository.
+1, especially because log messages are available offline and one gets a
better idea of what the changes is about on the Jenkins changes page.
If we all agree on it, we might want add a post-receive-hook that checks
the commit message for proper formatting.