Re: [ease-dev] Oomph Setup failed

[Raphael Geissler <raphael.geissler@xxxxxxxxx>]

2017-01-10 19:03 GMT+01:00 Christian Pontesegger <christian.pontesegger@xxxxxx>:
> Hi Raphael,
>
> great you could already implement it. Now lets see:
>>
>> https://github.com/jmrozanec/cron-utils. It uses Apache 2.0 license.
>
> The library looks fine, we should go with it.
>>
>> At the moment Unix cron syntax is used, so minimal time-interval is
>> one minute. With the library above we could also support Quartz cron
>> syntax, which has one second as minimal time-interval.
>> We should discuss if this is needed. Especially what happens if the
>> time-interval is smaller than the script execution-time. I don't know
>> at the moment what then will happen. Assuming new trigger will paused
>> as long as script is running...
>
> I guess minutes as a minimal interval should be fine. Scripts executed more
> often might have a real performance impact on eclipse. IMHO such things
> should be implemented in Java then.
> If the script execution takes longer that the script interval I would not
> trigger further executions. I would say as long as the script is running its
> trigger should be deactivated. Otherwise we would get more and more
> competing scripts which definitely would cause problems.

I will test what happens...

>> Now it would be nice if you can me support with a few technical things:
>> 1. I have included the new library by converting the jar to an OSGi
>> bundle and put it in my workspace. I think that this is not ok and we
>> have to get the library to the Orbit repository. Is that right? What
>> must be done?
>
> First time for me too. I will clarify on the procedure to push a library to
> orbit. For one thing we need to file a legal request. Quite likely we also
> need to prepare a commit for the orbit project. I will have a look into
> this. These things take some time and then we need to wait for the next
> orbit build before we can start depending on this lib.

I will wait for your feedback here...

>> 2. I have nothing changed within the pom files. Shall I try it myself
>> or is there anything special. Which Maven command must be triggered to
>> get sure that everything works fine?
>
> Depends how you implemented it. Did you create a new plug-in project? Then
> you need to copy over a pom from an existing project, adapt the naming and
> add a reference to it in the o.e.ease.releng/pom.xml. I can help on those
> things.
> If you did not add a new project, then nothing is to be changed.

I added a new test plug-in, so I will add/change the pom files. Which
command can I use to trigger a full build?

>> 3. How comes the code back to the repository. Unfortunately I have no
>> experience with gerrit. (I found this article:
>>
>> https://www.eclipse.org/community/eclipse_newsletter/2014/july/article3.php,
>> must I do this stuff?)
>
> In gerrit you have to commit your changes as a single commit. If you have
> multiple local commits, you have to squash them first into a single one.
> Make sure the commit message contains a signed-off and an author. For both
> use the email address of your eclipse account. Further you need to sign an
> ECA, see https://eclipse.org/legal/ecafaq.php for that. You can do this
> online, it helps eclipse to keep track of legal issues and is needed for the
> EPL licence which will be needed for all your code contributions.
> Your commit message also needs to refer to a bugzilla entry. Please create
> one as we do not have an open request for this topic already.
>
> For a commit message template see:
> https://wiki.eclipse.org/EASE/Contributor_Guide
>
> Afterwards push your commit. It will be picked up by gerrit and will trigger
> an automated build. No worries, it is not going to the master branch right
> away. After the build I will do a manual review, maybe comment on some
> implementation topics, code format, file headers and similar things. We
> might do 2 or three loops until the code is fine. Then I will take it over
> to the productive branch.

I will prepare that. Nevertheless I will wait until the Orbit stuff is
clarified...

>> P.S.: Exmaple script looks like this:
>> ---------------------------- CronJob.js -----------------
>> // cron: * * * * *, param1, param2
>
> Great, exactly as requested :)
>
> thanks for working on the topic!!!
>
> Christian
>
> _______________________________________________
> ease-dev mailing list
> ease-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/ease-dev

Raphael