Re: [ease-dev] Signature verification checks

[Christian Pontesegger <christian.pontesegger@xxxxxx>]

Hi Varun,

thanks for still working on the project. i commented your gerrit patches.


On 09/20/16 20:30, Varun Raval wrote:
> In include method of EnvironmentModule, instead of passing 
> url.openStream to inject method, now I am passing url so that we can 
> get URL string during check for signature, so that we can distinguish 
> it from dynamic code segments. I am not completely sure about all 
> consequences of last step. It is working nicely for signature checks.
I see that you try to detect URIs this way. Unfortunately this is not 
sufficient if you want to distinguish local/remote files. eg you might 
have URIs like "file://...", "workspace://...", "script://...". The 
change itself makes sense, but I would put it into a separate bug/topic.

Christian