[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [ease-dev] GSoC Signing Scripts
|
Hi Varun,
signature check belongs to the engine directly. I guess we discussed
that topic already some weeks ago. Think of a main script that is
correctly signed. When you check that in the launcher you might think
everything is fine. Now that script includes a second source that
contains unsigned code. It would load and execute it without checking
and without informing the user.
User popups would be something that needs to be registered to the engine
directly which then could run the callback in case of a problem. These
things are not in place so far and I really doubt that they will be
until pencils down by tomorrow.
Regarding your UI problem I would always use a treeviewer over a plain
tree. However this is not a pressing topic anymore so we might skip it
entirely.
Christian
On 08/20/2016 04:24 AM, Varun Raval wrote:
Hi Christian,
I uploaded the patchset [1] containing calls to SignatureCheck class
from various script execution entry points.
Initially SignatureCheck class was in org.eclipse.ease.ui.launching
package.
Since I was not able to call SignatureCheck class from
org.eclipse.ease packages because of cycle of dependencies, I have
kept it in org.eclipse.ease.sign.
Same is the reason for keeping IPreferenceConstants within same
package, because we need to check for preferences from SignatureCheck
class.
SignatureCheck class was set since long and it is already merged.
The thing remaining was calls to it from script execution entry points.
We also need to show the info of certificates in case of invalid or
untrusted certificates asking user whether he trusts this certificate
chain and giving user the option to execute or not.
I am using tree viewer for this.
In case of single certificate it is working fine.
But in case of multiple certificates, tree viewer is showing same
certificate in hierarchy. I have checked that certificates are stored
properly in the data structure that I have prepared, but still, tree
viewer is not working.
See 197 line onwards in SignatureCheck class.
[1]: https://git.eclipse.org/r/#/c/79396/
Thanks,
