Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ease-dev] Sign and Verify Script
Hi Christian,

If we add checks for signature in internal inject methods than won't it cause unnecessary overhead since dynamic code fragments are executed using it? Refer to this thread.

Thanks,

On Mon, Aug 8, 2016 at 11:26 PM <Christian.Pontesegger@xxxxxxxxxxxx> wrote:

Hi varun,

 

regarding checks: all these call scriptengine.execute which delegates to the internal inject method. Checking there for certificates would remove some headache for all other places script code could come from.

 

Christian

 

From: ease-dev-bounces@xxxxxxxxxxx [mailto:ease-dev-bounces@xxxxxxxxxxx] On Behalf Of Varun Raval
Sent: Sunday, August 07, 2016 9:53 PM
To: ease developer discussions
Subject: [ease-dev] Sign and Verify Script

 

Hi,

This week I worked on decorators, dialogs to perform signature, minor updates in Signature libraries and places where check for signature verification can be placed.

I updated the patch of dialogs to perform signature. Now, signature will be directly added to file and to update signature, for now, user can redo the signature using context menu.

Gerrit change: https://git.eclipse.org/r/#/c/76997/ Status:open 

Update in Signature library within SignatureHelper class regarding signature format.

Gerrit change: https://git.eclipse.org/r/#/c/78535/ Status: merged

I am trying to bring all constants within single file each for core library and UI library.

Gerrit change: https://git.eclipse.org/r/#/c/78512/ Status: open

 

Regarding decorators, I mentioned in the last thread, where I placed updates for decorators. Since that is not effective, I will be working on suggestion given by Christian.

I also worked on where to place checks for verifying signature.

Using method canExecute of org.eclipse.ease.ui.launching.SignatureCheck class,


Following are places where we can place checks:

org.eclipse.ease.ui.launching.EaseLaunchDelegate

After getting resource within launch method,

  • It is guaranteed to be local (either workspace or local file system, since otherwise resource will be null), we can set remote parameter to false while using canExecute.

 

org.eclipse.ease.ui.scripts.repository.impl.ScriptImpl

Within run(String) method, before scheduling engine,

  • Using getPath and isRemote methods, we can see script is remote or local and can call canExecute accordingly.

 

org.eclipse.ease.modules.EnvironmentModule

Within include() method, before injecting and after resolving file

  • Since here also, we can know whether file is remote or local, we can call canExecute accordingly.

 

Thanks,

--

Varun Raval

_______________________________________________
ease-dev mailing list
ease-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ease-dev
--
Varun Raval

Back to the top