| Re: [ease-dev] Sign and Verify Script |
Hi Varun, I merged [3] so you may continue with the other topics. For signature creation it would be even better to simply create the signature without any comment characters. They are script language dependent and therefore should not directly be connected to the signature creation algorithm. Having the plain text for the sig (ok to have the header and footer in there) we could then ask the codefactory to create a comment block out of it. Line delimiters then are platform specific. Instead of appending “\n“ you could use AbstractCodeFactory.LINE_DELIMITER which will use the system defaults. Regarding decorators update I think that the new approach is also not ideal regarding performance. We are doing these updates in the UI job, that means eclipse freezes while certificates are evaluated. Think of a slow http server where we need to fetch scripts from. Possibly we run into a timeout taking a minute or more. Users would think that eclipse crashed. Instead I suggest to verify script signatures while we scan those scripts for keywords. There we have to read the script anyway. Then lets store the signature state to the script. Therefore you would have to change the IScript and ScriptImpl classes. Then the decorator should simply display the stored state of the script. This way UI updates would be fast and the slow process of downloading the script source and verifying it would be done in a background job. Christian From: ease-dev-bounces@xxxxxxxxxxx [mailto:ease-dev-bounces@xxxxxxxxxxx] On Behalf Of Varun Raval Hi Christian, I have updated the bug related to decorators. See patch at [1]. I have placed update for decorators from within scheduler of UpdateRepositoryJob class so that update will happen regularly to check for external file changes and also for workspace script files whenever one changes. I am trying to replace several constants in libraries by referencing them using separate file for constants. Several changes are done in AbstractCodeParser class. There are other places which needs to be updated which will be done in consequent patches. See patch at [2]. Instead of directly appending signature using SignatureHelper class I am now trying to bring signature parameters and return them in proper format. So, now onwards, SignatureHelper class will be returning signature in proper format instead of directly appending to file and file operations can be done by caller if needed. See patch at [3]. After patch [3] happens, I will be able to go forward with perform signature dialog box bug. -- Varun Raval |
Attachment:
smime.p7s
Description: S/MIME cryptographic signature