Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ease-dev] [GSoC] Support generic script keywords
Thank you very much for your feedback Christian :)

I removed the unit test deliverable and added that part to first 3 deliverables. Also I changed the documentation deliverable by including about the eclipse help page. Please let me know if there is anything else to improve.

Thank you.

On Thu, Mar 24, 2016 at 5:22 PM, Christian Pontesegger <christian.pontesegger@xxxxxx> wrote:
Hi Vidura,

your proposal is fine, did not expect anything less :)
I would love to see 2 changes regarding the deliverables:

Unit testing: this should not be a separate deliverable, but start right with the first deliverable and should be an ongoing process.

Documentation: There will not be lots of public API necessary here, so JavaDocs for your internal stuff is fine. But it would be great if you could write some eclipse help pages in o.e.e.help to explain users how to use keywords.

Christian


On 03/23/2016 10:38 PM, Vidura Mudalige wrote:
Hi Christian,

I found the fireScriptEvent() method. It seems refactoring part can be done within a short period of time as you said.

BTW I shared the draft proposal with Eclipse Foundation through GSoC website. It would be great if you can give some feedback.

Thank you.

On Mon, Mar 21, 2016 at 11:25 PM, Christian Pontesegger <christian.pontesegger@xxxxxx> wrote:


On 03/21/2016 09:37 AM, Vidura Mudalige wrote:
Don't we have to do any change to the event creation? So the refactoring part is just pushing existing events into the event bus and creating separate event streams for each keyword?
 Currently we have a method called fireEvent() or something like this. It pushes events to previously registered listeners. Fist task is that this method additionally pushes events to the event bus. So existing functionality stays intact while we already have event bus messages available. Then we will look at listeners that react on already existing keywords. Instead of the current listener interface we change their implementation to use the event bus.

Refactoring of the given functionality is really simple and should only take a few days or even less.

Regarding the UI implementation, when we editing script keywords using properties view, what should happen to the actual script files? Should they change as well?

 Scripts already provide 2 storages for keywords: a) within the file -> in that case you have to alter the source of script files. b) in a metadata storage. Here you just need to set those keywords using a given API. Somehow the user needs to define where he wants to store properties to. We also need to visualize if a property is part of the script or overridden by the local user.

Christian

_______________________________________________
ease-dev mailing list
ease-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ease-dev



--
Vidura Mudalige
Undergraduate
Computer Science & Engineering
University of Moratuwa.


_______________________________________________
ease-dev mailing list
ease-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ease-dev


_______________________________________________
ease-dev mailing list
ease-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ease-dev



--
Vidura Mudalige
Undergraduate
Computer Science & Engineering
University of Moratuwa.

Back to the top