Re: [ease-dev] Issue of tooltip support

[Vidura Mudalige <vbmudalige@xxxxxxxxx>]

Thanks for the quick review Christian. It seems I have missed a lot of things regarding tests writing. I will try to write the test again and will push for the review as soon as I can.

Thank you. 

On Thu, Oct 29, 2015 at 7:51 PM, Christian Pontesegger <christian.pontesegger@xxxxxx> wrote:

When running unit tests a different eclipse application is used. While the UI is started, workbench services are not available. This run mode is different than what you see when you run these tests as JUnit Plugin test. Try to focus on your method calls and verify those calls.

Regarding your commit:
Do not parse the html pages for content. What if our help generator script changes? Your tests would fail. Instead focus on the functions that create the desired help address string and verify that,


To verify your tests locally you might want to run the maven build on your machine:

mvn -p test clean install

from the root folder of your repository.

Regarding the push problem, did you amend the last commit? Gerrit basically just accepts 1 commit. You cannot add another separated commit. Instead you select "amend previous commit" from the commit dialog, then it should work.


Christian

Am 29.10.2015 um 14:17 schrieb Vidura Mudalige:

Hi Christian,

I wrote some unit tests and pushed for the review. But the build was failed and I got the error "Workbench has not been created yet". Then I tried to push the change again. But now I cannot push it since remote rejects the commit. What might be the reason for this?

_______________________________________________
ease-dev mailing list
ease-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ease-dev

--

Vidura Mudalige

Undergraduate

Computer Science & Engineering

University of Moratuwa.