Re: [ease-dev] Editor code completion

[Vidura Mudalige <vbmudalige@xxxxxxxxx>]

Thanks for the quick review Christian.:) And big thank to Martin. This is the best I can expect. :)

On Tue, Aug 18, 2015 at 2:22 AM, Christian Pontesegger <christian.pontesegger@xxxxxx> wrote:

review done, code merged. Can't say that I am blocking you guys :)

Christian

Am 17.08.2015 um 21:07 schrieb Martin Kloesch:

Hi,

I added the getDescription method and use it to create the String that you get via the IContentProposals. I currently create it only for the ICompletionSources that are returned when calculations are created, because I think they will not be necessary any other place. Since the call-chain is just used internally to get the class for the look-up with the filter I do not see a reason to compute them there. If you need them in the call-chain as well I will calculate them for every entry.

I already pushed the code and  hope that the review is done soon so that you can continue your work there.

_______________________________________________
ease-dev mailing list
ease-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ease-dev

--

Vidura Mudalige

Undergraduate

Computer Science & Engineering

University of Moratuwa.