Re: [ease-dev] GSoC & vacation

[Christian Pontesegger <christian.pontesegger@xxxxxx>]

Hi Vidura,

as mentioned from Martin already it is important that you both align your strategies. Re using the parse results from Martin is an important topic.
He will need to call your code when providing code completion suggestions (as those topics may attach help content in an editor).
For editor popups you will need to trigger his engine to identify the token under your cursor. This engine will also deal with include files and modules loaded there, so it will be more powerful than the previous version which was a mere proof of concept.
I guess you both need to spend some time for testing, showing that your implementations work for different types of files. Would be great to see some unit tests for your implementations, too.

Then try to move all help hover related code to a separate package in the ease.ui plugin. It helps to cluster relevant parts of the code
The hovers for the JSDT editor belong in the ease.lang._javascript_.ui plugin as they quite likely will not work for other editors.

If you have some time left you can work on the look and feel. The final result should look as close as possible to the hovers people are used to from the java editor.

Finally unit tests are always welcome. There you could write some tests without UI interaction. Eg test that you can extract *some* help data for a given method name and module list.

HTH
Christian

On 05.08.2015 19:03, Vidura Mudalige wrote:

Hi Christian,

I am currently working on the part regarding "help hovers over editor content". Now I can get some selected text from the editor(the combo box) and display it as a tooltip. I am planning to scan the loaded modules to identify whether the selected text is a method or field from a module. Then I can easily display the correct tooltip using my previous code. Later I can improve the text selection mechanism to identify methods or fields based on the cursor position.  Am I following the correct path?

Regarding my previous work, I have implemented two parts "help hovers for modules explorer" and "help hovers for code completion suggestions". There are some work left regarding the look and feel of these tooltips. Also in help hovers for code completion suggestions, sometimes two tooltips are generated at the same time. It doesn't happen all the time. Therefore I will open a bug and try to fix it before the end of the project. Other than these issues I would like to get some feedback and suggestions for improvements from you regarding the functionality of these two parts. Then I can focus on those things as well during the next week.

Thank you.

On Wed, Aug 5, 2015 at 12:44 AM, Christian Pontesegger <christian.pontesegger@xxxxxx> wrote:

Hi guys,

I will be on vacation from 7th to 16th this month with no access to the internet. So if you need me to review urgent stuff you need to commit fast.
During my absence you could still work together on relevant topics. Therefore you need to pull the relevant change topics into your workspace.

Keep in mind that we have 'pencils down' on the 17th, with a final deadline on the 21st. So your code should be fully functional until the 17th. Then we have some more days for refactoring, cleanups, documentation, ...

Please also check that all relevant logic in your classes is documented, so people can follow up on your code more easily.

--
Christian
_______________________________________________
ease-dev mailing list
ease-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ease-dev

--

Vidura Mudalige

Undergraduate

Computer Science & Engineering

University of Moratuwa.

_______________________________________________
ease-dev mailing list
ease-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ease-dev