Re: [ease-dev] Definition of org.eclipse.ease.module.platform.Selector l

["GAUFILLET, PIERRE" <pierre.GAUFILLET@xxxxxxxxxx>]

Hi!

Thanks for your work Christian :)

Regarding the context, modelling modules target people wanting to provide advanced customizability to end users who are not skilled in Java/Eclipse. It is a typical use case for PolarSys members. For example, the teams of my company using Eclipse modellers sometimes need to automate project's specific actions like: 
 * changing the graphical style for all elements of a given type
 * extract/correlate complex information coming from several models (semantics, graphics, requirements, annotations)
 * modify systematically their model each time a given pattern is found
 * etc.

This is the primary reason why TOPCASED Scripting has been developed and why we are interested in EASE.

I still have to test your work, but I had a quick look to it this morning. I have one major remark: you have gathered in only one module all modelling modules. It means that if you need only EASE for Ecore scripting, you will anyway depends on UML and Papyrus (which increases the size of the product and may induce compatibility issues). I suggest therefore to re-split the module into o.e.e.modules.modeling, o.e.e.modules.modeling.uml  and o.e.e.modules.modeling.papyrus.

Regarding the FIXME tag in Papyrus module, I suggest removing completely the else statement from line 132 to 136 as the implementation of this method is anyway really partial.

At last, I have spotted a double copyright header in WorkbenchModule.java that should probably be fixed.

Pierre

-----Message d'origine-----
De : ease-dev-bounces@xxxxxxxxxxx [mailto:ease-dev-bounces@xxxxxxxxxxx] De la part de Christian Pontesegger
Envoyé : 31 August 2014 8:00 PM
À : ease-dev@xxxxxxxxxxx
Objet : Re: [ease-dev] Definition of org.eclipse.ease.module.platform.Selector lost?

Today I merged all modeling modules and required base classes and moved them to o.e.e.modules.
See
http://git.eclipse.org/c/ease/org.eclipse.ease.modules.git/commit/?id=9b3c42aaf5a95c2cf5ddbbef976c30844f3ce5c7

Code compiles and is integrated in the maven build. Yet I did not add a feature for it as I am not sure if its functionality is still working. I also re-added the selection extension point To work on modules you need to use the modules target platform, which adds all the modeling requirements not part of ease.core

I had to disable 1 method in PapyrusModule: createDiagram now throws a RuntimeException as I could not locate a needed classes (see FIXME in code).

regards
Christian

_______________________________________________
ease-dev mailing list
ease-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/ease-dev



The information in this e-mail is confidential. The contents may not be disclosed or used by anyone other than the addressee. Access to this e-mail by anyone else is unauthorised.
If you are not the intended recipient, please notify Airbus immediately and delete this e-mail.
Airbus cannot accept any responsibility for the accuracy or completeness of this e-mail as it has been sent over public networks. If you have any concerns over the content of this message or its Accuracy or Integrity, please contact Airbus immediately.
All outgoing e-mails from Airbus are checked using regularly updated virus scanning software but you should take whatever measures you deem to be appropriate to ensure that this message and any attachments are virus free.