Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [e4-dev] Merging E4 fragments into app model after E3 workbench has been loaded

Hi Tom,

I'm not sure what you mean with "compat semantics". Please elaborate.

Do you mean to run E4 code in an E3 based application?

Cheers,

Wim



On Sat, Jan 7, 2017 at 9:09 PM, Tom Schindl <tom.schindl@xxxxxxxxxxxxxxx> wrote:
The problem I have with your solution is that it introduces compat semantics to the pure e4 concepts (I admit that we see this very wrong strategy in the menu/toolbar renders and even the model but that does not make it acceptable :-) 

Tom

Von meinem iPhone gesendet

Am 07.01.2017 um 20:45 schrieb Wim Jongman <wim.jongman@xxxxxxxxx>:

Hi Erdal,

We have been working on this as well a while ago. If you want you can take a look at the unfinished solutions here:

https://github.com/E4Examples/importworkbenchbridge
https://git.eclipse.org/r/#/c/21111/
Bug 376486 - IDE not extendable via fragments or processors






On Fri, Jan 6, 2017 at 12:08 PM, Erdal Karaca <erdal.karaca.de@xxxxxxxxx> wrote:
Hi devs,
The ModelAssembler only merges fragments into the app model if it can find the parent to extend. If we have an E4 app with compat layer AND the fragments are extending elements generated within E3 workbench intitialization phase, the fragments are not merged.

I have experimented a bit with the internals of E4Application/ModelAssembler to load E4 fragments into the application model after the compat layer has loaded the E3 workbench.
The result is that it seems to be possible to merge E4 fragments into E3 API driven products, i.e. E4 with compat layer.

Now, I am not sure if I am missing some obvious points using this approach as seemed to work quite smoothly.
As the various renderes listen to model changes, I expect them to handle dynamically added elements properly.
Do you have or know of any concerns?

_______________________________________________
e4-dev mailing list
e4-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/e4-dev

_______________________________________________
e4-dev mailing list
e4-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/e4-dev

_______________________________________________
e4-dev mailing list
e4-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/e4-dev


Back to the top