| Re: [dtp-dev] Data Tools will not compile against Eclipse 4.31 / 2024-03 |
Brian,
One thing to note is that each p2 repository includes a link to the commit:
I'm not sure what the tag should look like; I'm just the releng
guy...
Please open an issue and let's discuss/track the details there.
Ed, thanks for fixing this so quickly!
Another request - is it possible to add a tag to the repo (or better, a release?) that corresponds to the build that makes it to SimRel? Looks like the last tag was in 2020.
Thanks!Brian
On Wed, Mar 6, 2024 at 3:13 AM Ed Merks via dtp-dev <dtp-dev@xxxxxxxxxxx> wrote:
_______________________________________________
It would be good to open an issue here:
We have one whole day before the SimRel RC2 deadline to address that issue.
On Mar 5, 2024, at 21:45, Brian Fernandes via dtp-dev <dtp-dev@xxxxxxxxxxx> wrote:
_______________________________________________The interfaces org.eclipse.ui.commands.ICommand / ICommandManager / IKeySequenceBinding (and possibly more) have been removed from Eclipse 4.31. Classes using these interfaces like AbstractSQLEditorTextHover will not compile against this release of Eclipse; other code may be affected as well.
According to a note here: https://github.com/eclipse-platform/eclipse.platform.ui/blob/R4_30_maintenance/bundles/org.eclipse.ui.workbench/Eclipse%20UI/org/eclipse/ui/commands/ICommand.java we are supposed to use the "org.eclipse.core.commands" plug-in.
If it helps, I found this commit in the sourceediting repo where use of this interface was modified to work with 4.31.
Given the 4.31 release in a little over a week, seems like something that must be addressed soon - unless I'm mistaken and have been looking at the wrong branch (master)!
Best,Brian
dtp-dev mailing list
dtp-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/dtp-dev
dtp-dev mailing list
dtp-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/dtp-dev
_______________________________________________ dtp-dev mailing list dtp-dev@xxxxxxxxxxx To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/dtp-dev
