[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
RE: [dsdp-tm-dev] FindBugs
|
True,
I haven't seen Eclipse find any of the following issues
which are potentially
very interesting to fix:
-
Bad attempt to compute absolute value of signed 32-bit
hashcode
-
Bad comparison of nonnegative value with negative
constant
-
Class defines clone() but doesn't implement
Cloneable
-
Incorrect lazy initialization and update of static
field
-
Inconsistent synchronizaton
-
Unsynchronized get method, synchronized set
method
...and several more...
I have personally especially found to appreciate FindBugs'
warnings with
respect to threading / synchronization issues which are
very hard to find
otherwise.
Some of these have been done by Benny Muskalla as part of
his
Google Summer of Code project this
year:
which is awsome, but Findbugs is still quite ahead of
Eclipse,
which I find totally OK since Eclipse is a Framework and
Findbugs
is the Expert in this case!
I agree with Rado though that the number one missing
feature
in findbugs is ability to tag reviewed false positives in a
way
that FB doesn't report them any more in the future -- API
Tooling
shows how that should be done with its "Add Problem
Filter"
quickfix, though I could also imagine related markup right
in the
code (//$FB-NO-BUG-1$ or similar)
Cheers,
--
Martin Oberhuber, Senior Member of Technical
Staff, Wind River
Target Management Project
Lead, DSDP PMC Member
I know FindBugs is a great tool
... and I know you just meant it as an example (as is often done with
FindBugs)
but, I can't help but point
out Eclipse itself can find those "silly NPE candidates" :)
It's under Preferences, Compiler,
Errors/Warnings, Potential Programming Problems, and there's two flavors (for
sure, and potential).
| From:
| "Oberhuber, Martin"
<Martin.Oberhuber@xxxxxxxxxxxxx>
|
| To:
| "Target Management developer
discussions" <dsdp-tm-dev@xxxxxxxxxxx>
|
| Date:
| 09/24/2008 08:28 PM
|
| Subject:
| [dsdp-tm-dev]
FindBugs |
Hi all,
here is a Blog about a new
FindBugs release, complete with a
ready-made properties file ideally suited for Eclipse:
http://www.jroller.com/andyl/entry/findbugs_update1
Who dares trying
this on TM and fix some? Note that
in the
current 3.1 Stream, we're not going to require
bugzilla's for each change. A checking with
[cleanup][fb] Fixed silly NPE
candidate
or
similar will just be fine...
Cheers,
--
Martin Oberhuber, Senior Member of Technical Staff, Wind River
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
_______________________________________________
dsdp-tm-dev mailing
list
dsdp-tm-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dsdp-tm-dev
