[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
[dsdp-tm-dev] Re: Please review API Javadoc Tags
|
ISystemFilter and ISystemFilterString both have concrete implementations
that look to me to be complete. I have no real problem removing the
@noimplement from these, I just didn't see the need. Tobias, please let me
know if you are implementing these directly and what other interfaces you
might need that I've tagged as @noimplement.?
Sorry about PropertyType, thought I caught all of those.
See my other note about @noextend on interfaces.
_______________________
David Dykstal
david_dykstal@xxxxxxxxxx
|------------>
| From: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|"Oberhuber, Martin" <Martin.Oberhuber@xxxxxxxxxxxxx> |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| To: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|David Dykstal/Rochester/IBM@IBMUS, "Schwarz, Tobias" <tobias.schwarz@xxxxxxxxxxxxx> |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Cc: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|"Target Management developer discussions" <dsdp-tm-dev@xxxxxxxxxxx> |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Date: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|04/23/08 07:28 PM |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Subject: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|Please review API Javadoc Tags |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
Hi Dave,
can you please review the tags that you set on
ISystemFilterPoolSelectionValidator
ISystemFilterPoolWrapper
ISystemFilterPoolWrapperInformation
ISystemContentsType
These have @noextend (which makes no sense for interfaces) but is
missing @noimplement.
I'm also surprised that you don't want clients to implement
ISystemFilter, or ISystemFilterString and related interfaces.
I thought that Tobias were implementing thse for the Wind
River filter implementations. Is this correct, Tobias? Please
check in RSE HEAD.
In PropertyType, I found an @noinstantiate, which is moot because
there are no public available constructors. I thus got rid of the tag.
Cheers,
--
Martin Oberhuber, Senior Member of Technical Staff, Wind River
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
