[dsdp-tm-dev] MessageFormat in SftpService / FTPService, and other probl

["Oberhuber, Martin" <Martin.Oberhuber@xxxxxxxxxxxxx>]

Hi Dave,

 

I found more problems with your checkin.

Most importantly, you've been a little too radical getting rid of MessageFormat:

 

In SftpFileService, the formatting of 
    SftpFileService_Msg_Progress

does require MessageFormat, because it uses NLS-specific formatting

of percent and Integers like {2,number,percent} which NLS.bind()

does not support.

 

Same is true for FTPService / FTP_File_Service_Monitor_Format.

 

Please revert your change.

 

In the DownloadListener and DStoreFileService, NLS-specific

replacement of the "%" character could also be done with

MessageFormat instead of the current hard-coded adding of

% character.

 

In SystemFileResources, MSG_FILE_CANNOT_BE_SAVED has a spurious > character at the end.

 

In ValidatorFileNameUnique (and the other validators), you might want to

use 3 static variables for the SimpleSystemMessage objects, rather than

creating new objects each time

 

In ShellStrings.properties there is still MSG_OPERATION_CANCELLED

(should be ...CANCELED)

 

In RSECoreRegistry, when you switch from MessageFormat to NLS.bind()

you need to replace the double '' characters by single ' character (at least

I think so: please test to verify

 

 

Thanks,

--

Martin Oberhuber, Senior Member of Technical Staff, Wind River

Target Management Project Lead, DSDP PMC Member

http://www.eclipse.org/dsdp/tm