[dsdp-tm-dev] RE: Renamed ftpFileEntryParsers

["Oberhuber, Martin" <Martin.Oberhuber@xxxxxxxxxxxxx>]

Hello Javier,

 

actually I think I'd like to see that extension point renamed to

 

   ftpListingParsers

   "FTP Listing Parsers"

 

because what it does, is contribute a parser for the FTP "Dir" listing.

I think that users are more likely to find it and understand what it does.

If it were named

 

   ftpFileEntryParsers

   "FTP File Entry Parsers"

 

it's not immediately clear what an FTP File Entry is. Even though it

uses the Commons.Net class FTPFileEntryParser for most of its

work, I think the ftpListingParser does more than that (because, for

instance, it also passes the dirCommandOptions).

 

What do you think?

Cheers,
--
Martin Oberhuber
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm

 

---

From: javier.montalvoorus@xxxxxxxxxxx [mailto:javier.montalvoorus@xxxxxxxxxxx]
Sent: Wednesday, May 16, 2007 5:02 PM
To: Oberhuber, Martin
Cc: Target Management developer discussions
Subject: Re: Renamed ftpFileEntryParsers

Hi Martin,

Many thanks for the review, I'll fix the minor issues listed in the previous email.

Regards,

Javier Montalvo Orús
Development Tools
Symbian Software Limited.

"Oberhuber, Martin" <Martin.Oberhuber@xxxxxxxxxxxxx>

16/05/2007 14:51

To	<javier.montalvoorus@xxxxxxxxxxx>
cc	"Target Management developer discussions" <dsdp-tm-dev@xxxxxxxxxxx>
Subject	Renamed ftpFileEntryParsers

Hi Javier,

I renamed the FTP listing parser extension point from
 ftpFileEntryParser
to
 ftpFileEntryParsers
in order to be consistent with the rest of Eclipse.

I also added it to the ISV Docs, see
http://dsdp.eclipse.org/help/latest/index.jsp?topic=/org.eclipse.rse.doc
..isv/reference/extension-points/org_eclipse_rse_subsystems_files_ftp_ftp
FileEntryParsers.html

I'm noticing few minor issues:
* Examples are not on the help page although they are in the .exsd
* Examples in the .exsd seem outdated since they use a "name" attribute

Cheers,
--
Martin Oberhuber
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm

---

********************************************************************** Symbian Software Ltd is a company registered in England and Wales with registered number 4190020 and registered office at 2-6 Boundary Row, Southwark, London, SE1 8HP, UK. This message is intended only for use by the named addressee and may contain privileged and/or confidential information. If you are not the named addressee you should not disseminate, copy or take any action in reliance on it. If you have received this message in error please notify postmaster@xxxxxxxxxxx and delete the message and any attachments accompanying it immediately. Neither Symbian nor any of its Affiliates accepts liability for any corruption, interception, amendment, tampering or viruses occurring to this message in transit or for any message sent by its employees which is not in compliance with Symbian corporate policy. **********************************************************************