[dsdp-tm-dev] persistence manager changes

[David Dykstal <dykstal@xxxxxxx>]

The following breaking API changes are being made to the persistence  
manager
interface to have it work entirely with profiles as the unit of  
persistence.
This results in several changes with the major ones being in the  
persistence
manager and minor ones being made in the model object hierarchy and  
the filter
pool and filter pool reference framework. The latter are needed since  
the
persistence manager manages the restoration of filter pool references
(particularly forward references).

This cleans up the interface considerably while extending the  
function by
allowing multiple persistence providers and for migration between  
persistent
forms.

Since this is a breaking change. I need to post this and request  
comments prior
to committing these changes.

I will be attaching a patch of the complete change set for review.

See bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=170932

org.eclipse.rse.core.persistence.IRSEPersistenceManager
removed commit(SystemFilterPoolManager)
removed commit(ISystemHostPool)
removed commit(ISystemProfile) RENAMED
removed commit(ISystemProfileManager)
added commitProfile(ISystemProfile) RENAMED FROM
added commitProfiles()
removed deleteProfile(profileName) REPLACED
added deleteProfile(persistenceProvider, profileName) REPLACEMENT
added getPersistenceProvider(providerId)
added getPersistenceProviderIds()
added migrateProfile(profile, newPersistenceProvider)
registerPersistenceProvider() RENAMED FROM
removed registerRSEPersistenceProvider() RENAMED
removed restore(ISystemFilterPool)
removed restore(ISystemHostPool)
removed restore(ISystemProfileManager)
removed restoreFilterPool(String)
removed restoreFilterPoolManager(...)
added restoreProfile(persistenceProvider, profileName)
added restoreProfiles() to restore all profiles

org.eclipse.rse.core.SystemResourceManager
removed getProfileFolder. This has been obsolete for some time.  
Profile folders
are now the province of the persistence providers and have no meaning.

org.eclipse.rse.core.filters.ISystemFilterPool
removed the instance method createSystemFilterPool(String, boolean,  
boolean
boolean). It bad practice to have an instance method as a factory  
method for
the same class unless one is creating immutable objects based on a  
previous
instance. This were only two uses in the base platform and these have  
been
removed.

org.eclipse.rse.core.filters.ISystemFilterPoolReferenceManager
changed addReferenceToSystemFilterPool to take only a string  
argument. The
filter pool manger argument is redundant in that the reference string  
contains
a means of resolving it.

org.eclipse.rse.core.filters.SystemFilterPoolManager
removed setNameGen - redundant method a leftover artifact from the  
generated
code days.

org.eclipse.rse.core.model.IPersistableContainer
removed beginRestore() and endRestore() - no longer needed because of  
changes
in the persistence manager.

org.eclipse.rse.core.model.ISystemProfileManager
added addSystemProfile() for use by the persistence manager
added getSize() that returns the number of profiles being managed

org.eclipse.rse.core.model.ISystemRegistry
removed getSystemFilterPool() - it was manufacturing a fake system  
filter pool
so that an instance method could be accessed. bad practice. no longer  
needed.

org.eclipse.rse.core.model.RSEPersistableObject
removed beginRestore() and endRestore(). No longer needed by the  
persistence
manager.

org.eclipse.rse.core.subsystems.AbstractDelegatingConnectorService
removed beginRestore() and endRestore(). No longer needed by the  
persistence
manager.

org.eclipse.rse.ui.model.SystemRegistry
removed getSystemFilterPool - it was manufacturing a fake system  
filter pool so
that an instance method could be accessed. bad practice. no longer  
needed.