[dsdp-tm-dev] RE: Moving filters from UI to core

[David Dykstal <david_dykstal@xxxxxxxxxx>]

I'm not that hung up on the package name. We can use either, but once
chosen we'll need to stick to it. I also agree that we'll probably never
switch the plugin again.

There are two packages as a result of the earlier refactoring. The
org.eclipse.rse.core.filters package did not exist in the earlier IBM
versions. It was manufactured when we began to move things into core as we
removed UI dependencies.
_______________________
David Dykstal
david_dykstal@xxxxxxxxxx


                                                                           
             "Oberhuber,                                                   
             Martin"                                                       
             <Martin.Oberhuber                                          To 
             @windriver.com>           David Dykstal/Rochester/IBM@IBMUS   
                                                                        cc 
             03/30/2007 08:57          "Target Management developer        
             AM                        discussions"                        
                                       <dsdp-tm-dev@xxxxxxxxxxx>           
                                                                   Subject 
                                       RE: Moving filters from UI to core  
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           




I like rse.core.filters because they are in the core
plugin, and to indicate that they are non-UI. I don't
think we'd ever move them to a different plugin again.

What was the package name in RSE 1.x ? Did we have more
in rse.filters or more in rse.core.filters? It does not
really matter because migrators from 1.x to 2.x will
"organize imports" anyways, I'm just curious.

Why are there 2 different packages right now?

Cheers,
--
Martin Oberhuber
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm

> -----Original Message-----
> From: David Dykstal [mailto:david_dykstal@xxxxxxxxxx]
> Sent: Friday, March 30, 2007 2:51 PM
> To: Oberhuber, Martin
> Cc: Target Management developer discussions
> Subject: Re: Moving filters from UI to core
>
> With all the reorganization I'm surprised we don't break more
> builds :)
>
> I was thinking the same thing. However, I'm not sure we want a
> "core.filters". The packages probably should not contain references to
> their plugins unless that is the purpose of the package.
> "core" might not
> make sense in a lot of cases. "ui" probably does in most.
>
> Anyway, thinking along those lines, it might be best to move
> the types from
> org.eclipse.rse.core.filters to org.eclipse.rse.filters.
> _______________________
> David Dykstal
> david_dykstal@xxxxxxxxxx
>
>
>
>
>              "Oberhuber,
>
>              Martin"
>
>              <Martin.Oberhuber
>           To
>              @windriver.com>           David
> Dykstal/Rochester/IBM@IBMUS
>
>           cc
>              03/30/2007 07:13          "Target Management
> developer
>              AM                        discussions"
>
>
> <dsdp-tm-dev@xxxxxxxxxxx>
>
>      Subject
>                                        Moving filters from UI
> to core
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> Hi Dave,
>
> you won another "I broke the Build" award :-)
>
> When removing the "filters/" source folder from UI,
> you updated the .classpath file but forgot updating
> the build.properties file for the nightly build.
>
> No problem, I fixed it... another reason for removing
> the persistence/ source folder in core, IMHO.
> I also fixed the doc.isv's options.txt file which
> also had a dangling reference to ui/filters.
>
> The one question I stil have is, why do we have
> separate packages for
>   org.eclipse.rse.core.filters
>   org.eclipse.rse.filters
>
> couldn't the filters just go into core.filters now?
>
> Cheers,
> --
> Martin Oberhuber
> Wind River Systems, Inc.
> Target Management Project Lead, DSDP PMC Member
> http://www.eclipse.org/dsdp/tm
> -----Original Message-----
> From: dsdp-tm-cvs-commit-bounces@xxxxxxxxxxx
> [mailto:dsdp-tm-cvs-commit-bounces@xxxxxxxxxxx] On Behalf Of
> Eclipse CVS
> Genie
> Sent: Thursday, March 29, 2007 10:41 PM
> To: dsdp-tm-cvs-commit@xxxxxxxxxxx
> Subject: [dsdp-tm-cvs-commit]
> ddykstalorg.eclipse.tm.rse/plugins/org.eclipse.rse.core/src/or
> g/eclipse/
> rse/filtersSystemFilterSimple.java SystemFilterReference.java
>
> Update of
> /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.core/
> src/org/ec
> lipse/rse/filters
> In directory node3:/tmp/cvs-serv29428/src/org/eclipse/rse/filters
>
> Added Files:
>              SystemFilterSimple.java SystemFilterReference.java
> Log Message:
> [168973] Stage 3 - move filter packages to core plugin
>
>
>