Re: [dsdp-ercp-dev] Test_org_eclipse_swt_graphics_Font.java failure

[Mark Rogalski <rogalski@xxxxxxxxxx>]

Sounds good to me.

<petru.motrescu@xxxxxxxxx>
Sent by: dsdp-ercp-dev-bounces@xxxxxxxxxxx

05/21/2008 06:20 AM

Please respond to
DSDP ercp list <dsdp-ercp-dev@xxxxxxxxxxx>

To	<dsdp-ercp-dev@xxxxxxxxxxx>
cc
Subject	[dsdp-ercp-dev] Test_org_eclipse_swt_graphics_Font.java failure

Hello,

The eRCP version of Test_org_eclipse_swt_graphics_Font.test_ConstructorLorg_eclipse_swt_graphics_Device$Lorg_eclipse_swt_graphics_FontData fails on our S60 implementation due to incorrect testing:

test_ConstructorLorg_eclipse_swt_graphics_Device$Lorg_eclipse_swt_graphics_FontData() {
...
       // test that FontData is set correctly  
       FontData data = "" FontData();
       Font font = new Font(display,data);
       FontData[] returnedData = font.getFontData();
       assertEquals(data,returnedData[0]);
       font.dispose();
}

FontData.FontData(), in our implementation, sets the font name to "" (empty string). That is how other implementations behave also.

returnedData[0] will of course have a font name different than "" (empty string).

The Bug 217849: https://bugs.eclipse.org/bugs/show_bug.cgi?id=217849 describes the same problem for SWT.
The SWT version of the Font JUnit test has been fixed but the eRCP version has been left unfixed.
The fix for SWT version consists of removal of this test step. See revision Revision 1.16: http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.swt.tests/JUnit%20Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_graphics_Font.java?revision=1.16&view=markup

I am planning to apply the same fix for the eRCP version of the Font JUnit test.

Best regards,
Petru _______________________________________________
dsdp-ercp-dev mailing list
dsdp-ercp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dsdp-ercp-dev