Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [dsdp-dd-dev] M5 Testing and DSF plugin renaming
Thanks Marc,
I renamed the package you pointed out and committed the patch as well.
Cheers,
Pawel


Marc Khouzam wrote:
After Francois found this bug, I got to thinking that we should grep for plugin names inside of string that should have been changed (compiler would not have found those).
I found a couple of things.
 
I didn't know if these were a big deal or not, but I figure: better safe than sorry.
 
The plugin org.eclipse.dd.tests.dsf still has some code under package org.eclipse.dd.dsf.tests.service instead of new package
org.eclipse.dd.tests.dsf.service.  If those are changed, both MultiInstanceTestService and ServiceTests contain a string that will need to be changed.
 
Besides that, the following patch fixes all the other strings I found:
 
### Eclipse Workspace Patch 1.0
#P org.eclipse.dd.gdb
Index: src/org/eclipse/dd/gdb/launching/GdbLaunchDelegate.java
===================================================================
RCS file: /cvsroot/dsdp/org.eclipse.dd.dsf/plugins/org.eclipse.dd.gdb/src/org/eclipse/dd/gdb/launching/GdbLaunchDelegate.java,v
retrieving revision 1.1
diff -u -r1.1 GdbLaunchDelegate.java
--- src/org/eclipse/dd/gdb/launching/GdbLaunchDelegate.java     13 Feb 2008 20:27:01 -0000      1.1
+++ src/org/eclipse/dd/gdb/launching/GdbLaunchDelegate.java     14 Feb 2008 21:05:23 -0000
@@ -57,7 +57,7 @@
 public class GdbLaunchDelegate extends AbstractCLaunchDelegate
     implements ILaunchConfigurationDelegate2
 {
-    public final static String GDB_DEBUG_MODEL_ID = "org.eclipse.dd.dsf.gdb"; //$NON-NLS-1$
+    public final static String GDB_DEBUG_MODEL_ID = "org.eclipse.dd.gdb"; //$NON-NLS-1$
    
        /* (non-Javadoc)
         * @see org.eclipse.cdt.launch.AbstractCLaunchDelegate#launch(org.eclipse.debug.core.ILaunchConfiguration, java.lang.String, org.eclipse.debug.core.ILaunch, org.eclipse.core.runtime.IProgressMonitor)
Index: plugin.xml
===================================================================
RCS file: /cvsroot/dsdp/org.eclipse.dd.dsf/plugins/org.eclipse.dd.gdb/plugin.xml,v
retrieving revision 1.1
diff -u -r1.1 plugin.xml
--- plugin.xml  13 Feb 2008 20:27:01 -0000      1.1
+++ plugin.xml  14 Feb 2008 21:05:23 -0000
@@ -17,8 +17,8 @@
          point="org.eclipse.cdt.debug.core.BreakpointExtension">
       <breakpointExtension
             class="org.eclipse.dd.gdb.breakpoints.CBreakpointGdbThreadsFilterExtension"
-            debugModelId="org.eclipse.dd.dsf.gdb"
-            id="org.eclipse.dd.dsf.gdb.threadFilter"
+            debugModelId="org.eclipse.dd.gdb"
+            id="org.eclipse.dd.gdb.threadFilter"
             markerType="org.eclipse.cdt.debug.core.cBreakpointMarker">
       </breakpointExtension>
    </extension>
#P org.eclipse.dd.mi
Index: src/org/eclipse/dd/mi/service/MIBreakpointsManager.java
===================================================================
RCS file: /cvsroot/dsdp/org.eclipse.dd.dsf/plugins/org.eclipse.dd.mi/src/org/eclipse/dd/mi/service/MIBreakpointsManager.java,v
retrieving revision 1.1
diff -u -r1.1 MIBreakpointsManager.java
--- src/org/eclipse/dd/mi/service/MIBreakpointsManager.java     13 Feb 2008 20:34:28 -0000      1.1
+++ src/org/eclipse/dd/mi/service/MIBreakpointsManager.java     14 Feb 2008 21:05:25 -0000
@@ -79,7 +79,7 @@
 public class MIBreakpointsManager extends AbstractDsfService implements IBreakpointManagerListener, IBreakpointListener
 {
     // Note: Find a way to import this (careful of circular dependencies)
-    public final static String GDB_DEBUG_MODEL_ID = "org.eclipse.dd.dsf.gdb"; //$NON-NLS-1$
+    public final static String GDB_DEBUG_MODEL_ID = "org.eclipse.dd.gdb"; //$NON-NLS-1$
 
     // Extra breakpoint attributes
     private static final String ATTR_DEBUGGER_PATH   = MIPlugin.PLUGIN_ID + ".debuggerPath";   //$NON-NLS-1$
#P org.eclipse.dd.tests.dsf
Index: src/org/eclipse/dd/tests/dsf/events/EventTest.java
===================================================================
RCS file: /cvsroot/dsdp/org.eclipse.dd.dsf/plugins/org.eclipse.dd.tests.dsf/src/org/eclipse/dd/tests/dsf/events/EventTest.java,v
retrieving revision 1.1
diff -u -r1.1 EventTest.java
--- src/org/eclipse/dd/tests/dsf/events/EventTest.java  13 Feb 2008 20:56:28 -0000      1.1
+++ src/org/eclipse/dd/tests/dsf/events/EventTest.java  14 Feb 2008 21:05:25 -0000
@@ -35,7 +35,7 @@
         fExecutor = new TestDsfExecutor();
        
         fExecutor.submit(new DsfRunnable() { public void run() {
-            fSession = DsfSession.startSession(fExecutor, "org.eclipse.dd.dsf.tests"); //$NON-NLS-1$
+            fSession = DsfSession.startSession(fExecutor, "org.eclipse.dd.tests.dsf"); //$NON-NLS-1$
         }}).get();
        
         StartupSequence startupSeq = new StartupSequence(fSession);
Index: plugin.xml
===================================================================
RCS file: /cvsroot/dsdp/org.eclipse.dd.dsf/plugins/org.eclipse.dd.tests.dsf/plugin.xml,v
retrieving revision 1.1
diff -u -r1.1 plugin.xml
--- plugin.xml  13 Feb 2008 20:56:28 -0000      1.1
+++ plugin.xml  14 Feb 2008 21:05:25 -0000
@@ -6,13 +6,13 @@
          point="org.eclipse.ui.views">
       <category
             name="DSF Tests"
-            id="org.eclipse.dd.dsf.tests.model">
+            id="org.eclipse.dd.tests.dsf.model">
       </category>
       <view
             name="Model Test View"
-            category="org.eclipse.dd.dsf.tests.model"
-            class="org.eclipse.dd.dsf.tests.model.ModelTestsView"
-            id="org.eclipse.dd.dsf.tests.model.ModelTestView">
+            category="org.eclipse.dd.tests.dsf.model"
+            class="org.eclipse.dd.tests.dsf.model.ModelTestsView"
+            id="org.eclipse.dd.tests.dsf.model.ModelTestView">
       </view>
    </extension>
 </plugin>
#P org.eclipse.dd.gdb.ui
Index: plugin.xml
===================================================================
RCS file: /cvsroot/dsdp/org.eclipse.dd.dsf/plugins/org.eclipse.dd.gdb.ui/plugin.xml,v
retrieving revision 1.1
diff -u -r1.1 plugin.xml
--- plugin.xml  13 Feb 2008 20:32:21 -0000      1.1
+++ plugin.xml  14 Feb 2008 21:05:26 -0000
@@ -42,9 +42,9 @@
 
    <extension point="org.eclipse.ui.propertyPages">
          <page class="org.eclipse.dd.gdb.internal.ui.breakpoints.CBreakpointGdbThreadFilterPage"
-            id="org.eclipse.dd.dsf.gdb.breakpoint.filtering"
+            id="org.eclipse.dd.gdb.breakpoint.filtering"
             name="Filter">
-         <filter name="debugModelId" value="org.eclipse.dd.dsf.gdb"/>
+         <filter name="debugModelId" value="org.eclipse.dd.gdb"/>
          <enabledWhen>
             <adapt type="org.eclipse.cdt.debug.core.model.ICBreakpoint"/>
          </enabledWhen>
 
 
 
-----Original Message-----
From: dsdp-dd-dev-bounces@xxxxxxxxxxx [mailto:dsdp-dd-dev-bounces@xxxxxxxxxxx]On Behalf Of Pawel Piech
Sent: Thursday, February 14, 2008 2:59 PM
To: Device Debugging developer discussions
Subject: Re: [dsdp-dd-dev] M5 Testing and DSF plugin renaming

Ah, the first casualty of the plugin renaming.  I updated the .options file and MIPlugin and checked them in.  Please update and try it now.

Cheers,
Pawel

Francois Chouinard wrote:
Hi,

I can no longer find the MI messages tracing flag in the launch configuration. Was it moved in a not-so-obvious location or just dropped?

I rely a bit on it to perform my verifications during the manual tests...

Regards,
/fc


_______________________________________________
dsdp-dd-dev mailing list
dsdp-dd-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dsdp-dd-dev
  


_______________________________________________
dsdp-dd-dev mailing list
dsdp-dd-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dsdp-dd-dev

Back to the top