Re: [cross-project-issues-dev] ACTION REQUIRED from RAP / REDDEER / WEBT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]

Re: [cross-project-issues-dev] ACTION REQUIRED from RAP / REDDEER / WEBTOOLS - respin of Eclipse Platform RC2a and the status on removing slf4j 2.0.0 alpha

From: "Kit Lo" <kitlo@xxxxxxxxxx>
Date: Fri, 11 Jun 2021 18:14:28 -0400
Delivered-to: cross-project-issues-dev@xxxxxxxxxxx
List-archive: <https://www.eclipse.org/mailman/private/cross-project-issues-dev/>
List-help: <mailto:cross-project-issues-dev-request@eclipse.org?subject=help>
List-subscribe: <https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev>, <mailto:cross-project-issues-dev-request@eclipse.org?subject=subscribe>
List-unsubscribe: <https://www.eclipse.org/mailman/options/cross-project-issues-dev>, <mailto:cross-project-issues-dev-request@eclipse.org?subject=unsubscribe>

Eclipse and Equinox build for SimRel 2021-06 RC2 (rebuild for Jetty 10.0.5) has been contributed.

Regards,
Kit Lo
Eclipse Babel Project Lead
IBM Eclipse SDK (IES) Technical Lead and Release Manager

Sravan K Lakkimsetti---06/11/2021 04:57:50 PM---From: Sravan K Lakkimsetti/India/IBM To: "Cross project issues" <cross-project-issues-dev@xxxxxxxxxxx>

From: Sravan K Lakkimsetti/India/IBM
To: "Cross project issues" <cross-project-issues-dev@xxxxxxxxxxx>
Cc: Kit Lo/Raleigh/IBM@IBM
Date: 06/11/2021 04:57 PM
Subject: Re: [cross-project-issues-dev] ACTION REQUIRED from RAP / REDDEER / WEBTOOLS - respin of Eclipse Platform RC2a and the status on removing slf4j 2.0.0 alpha

Platform rebuild has been started. Kitlo will be doing the contribution after the build is ready.

Thanks
Sravan

From: Jonah Graham <jonah@xxxxxxxxxxxxxxxx>
Sent: 12 June 2021 01:25
To: Cross project issues <cross-project-issues-dev@xxxxxxxxxxx>
Subject: [EXTERNAL] Re: [cross-project-issues-dev] ACTION REQUIRED from RAP / REDDEER / WEBTOOLS - respin of Eclipse Platform RC2a and the status on removing slf4j 2.0.0 alpha

Thanks Joakim and the rest of the Jetty project for the fast turnarounds on your releases!

Hi folks,

Thanks to the Jetty project doing their release of 10.0.5 we are now ready to respin what needs to change.

@Ondrej I don't think there is anything to do for Reddeer anymore? Thank you for your earlier contributions.

Eclipse Platform / Webtools / RAP - please let me know when your pieces are in so that I can build the EPP build and Fred can do the simrel release prep work.

Jonah

~~~
Jonah Graham
Kichwa Coders
www.kichwacoders.com

On Fri, 11 Jun 2021 at 15:29, Joakim Erdfelt <joakim.erdfelt@xxxxxxxxx> wrote:
Eclipse Jetty 10.0.5 release (not snapshot) is now available on maven central.

- Joakim

On Fri, Jun 11, 2021 at 5:48 AM Sravan K Lakkimsetti <sravankumarl@xxxxxxxxxx> wrote:

Platform testing is also complete. Verified the help feature and no issues found.

Thanks

Sravan

From:

Markus Knauer <

mknauer@xxxxxxxxxxxxxxxxx

Sent:

11 June 2021 15:50

To:

Cross project issues <

cross-project-issues-dev@xxxxxxxxxxx

Subject:

[EXTERNAL] Re: [cross-project-issues-dev] ACTION REQUIRED from RAP / REDDEER / WEBTOOLS - respin of Eclipse Platform RC2a and the status on removing slf4j 2.0.0 alpha

I finished my testing of local RAP builds based on the Jetty 10.0.5 snapshot consumed via WTP p2 repository, and with the latest platform build from yesterday:

Everything is looking good!

For those interested in the details: My tests were based on the Gerrit changes

#181804

and

#181803

and cover the installation of the RAP Tools into the new Eclipse SDK build, and the creation of several RAP demo projects with the new RAP Runtime. All this worked flawlessly and only the expected bundle versions from Jetty and SLF4J were installed. Now I am looking forward to the final Jetty build.

Thanks

Markus

On Fri, 11 Jun 2021 at 03:09, Jonah Graham <

jonah@xxxxxxxxxxxxxxxx

> wrote:

On Thu, 10 Jun 2021 at 21:07, Jonah Graham <

jonah@xxxxxxxxxxxxxxxx

> wrote:

The local build of simrel worked perfectly well - The expected 10.0.5 snapshot version* was there. You can see a log of the build and tree of the output directory attached.

Because RAP only provided me a private build for the 10.0.5 snapshot test which I used for my local tests, the local build doesn't match

https://download.eclipse.org/staging/2021-06/

. The staging repo has no slf4j (great!) but has two versions of Jetty (as expected).

I have built and smoke tested (basic operation, help, checked which versions are installed of jetty and slf4j) EPP packages locally against my local simrel build and all looks good. I am not running the EPP build against the public staging repo. Other than the final versions of Jetty we can do preliminary testing on that ahead of the final build.

I am *now* running the EPP build....

So now we wait for the official 10.0.5 release of Jetty and we'll be good to go.

Jonah

* The Platform and WTP repackaging of 10.0.5-SNAPSHOT took different approaches, so while they are built from the same maven coordinates, the ones in platform are version 10.0.5.SNAPSHOT and the ones from webtools is 10.0.5.20210610181657

~~~
Jonah Graham
Kichwa Coders

www.kichwacoders.com

On Thu, 10 Jun 2021 at 18:50, Jonah Graham <

jonah@xxxxxxxxxxxxxxxx

> wrote:

I have just seen that WTP has done the simrel contribution (thanks Nitin).

RAP have provided me a private build.

I am building everything locally now and will advise later today.

Thanks,

Jonah

On Thu., Jun. 10, 2021, 18:47 Jonah Graham, <

jonah@xxxxxxxxxxxxxxxx

> wrote:

I was curious whether there is any changes to rerdeer needed going forward now that it isn't republishing SLF4J alpha.

Perhaps there is nothing more needed.

I assume the WTP update is coming soon. Nitin, let me know if you need anything in this regard.

Thanks

Jonah

On Thu., Jun. 10, 2021, 18:37 Ondrej Dockal, <

odockal@xxxxxxxxxx

> wrote:

Hi Jonah,

I have rebuilt my release update site, though, anything except reddeer bundles timestamps have changed, as expected. But to initiate an aggregator validation I have prepared a gerrit commit (without actual change to aggrcon file) [1]. I can probably wait for [2] WTP change to rebase and rerun to make sure we are good.

[1]:

https://git.eclipse.org/r/c/simrel/org.eclipse.simrel.build/+/181811

[2]:

https://git.eclipse.org/r/c/simrel/org.eclipse.simrel.build/+/181810

On Thu, Jun 10, 2021 at 6:50 PM Jonah Graham <

jonah@xxxxxxxxxxxxxxxx

> wrote:

Hi folks,

Sravan has provided me with a link to what should represent Platform's contribution based on the jetty snapshot.

I don't think we need to wait for a respin of the snapshot for the source bundle issue that Sravan identified.

If other projects (RAP / Webtools/ Reddeer) can do the same, or provide me with build instructions I can smoke test the integration of everything in SimRel/EPP and make sure it all looks good and try to report back to Jetty so they can make their release.

Thanks

Jonah

~~~
Jonah Graham
Kichwa Coders

www.kichwacoders.com

On Thu, 10 Jun 2021 at 12:26, Sravan K Lakkimsetti <

sravankumarl@xxxxxxxxxx

> wrote:

Triggered a platform build with latest 10.0.5-SNAPSHOT. But there is issue in the source bundles as they contain temporary files

https://github.com/eclipse/jetty.project/issues/6354#issuecomment-858764165

Thanks

Sravan

From:

Jonah Graham <

jonah@xxxxxxxxxxxxxxxx

Sent:

10 June 2021 21:36

To:

Cross project issues <

cross-project-issues-dev@xxxxxxxxxxx

Subject:

[EXTERNAL] Re: [cross-project-issues-dev] ACTION REQUIRED from RAP / REDDEER / WEBTOOLS - respin of Eclipse Platform RC2a and the status on removing slf4j 2.0.0 alpha

Hi folks,

The snapshot is ready

https://github.com/eclipse/jetty.project/issues/6354#issuecomment-858733158

Thanks,

Jonah

On Thu., Jun. 10, 2021, 10:23 Jonah Graham, <

jonah@xxxxxxxxxxxxxxxx

> wrote:

Hi folks,

We are making very good progress on resolving this issue, in no part thanks to everyone that has been super responsive in updating their bits.

I checked all the EPP packages and (as expected) only JEE has slf4j.api_2.0.0.alpha1.jar. All the packages (also as expected) have org.slf4j.api_1.7.30.v20200204-2150.jar (including JEE).

The Jetty project is just about to push out a snapshot (

https://github.com/eclipse/jetty.project/issues/6390

) of 10.0.5 that fully resolves the slf4j 2.0.0 alpha1 dependency so that the SimRel and JEE package won't have alpha1 jar anymore.

To reduce the change of a turnaround time again we can collectively test that the 10.0.5 snapshot resolves all the issues. Note that this a further 10.0.5 snapshot than we had yesterday.

RIght now, I don't know how to do this test without a full respin of everything (platform , redeer(?) , webtools, rap).

Any suggestions are very welcome.

Thanks,
Jonah

~~~
Jonah Graham
Kichwa Coders

www.kichwacoders.com

On Wed, 9 Jun 2021 at 16:56, Ondrej Dockal <

odockal@xxxxxxxxxx

> wrote:

Jonah, thanks for taking care of this. If we will revert it after RedDeer is pushed, I think it is safe to give it a try. Also, If Jetty should be built somewhere with a fix it might provide a space for updating all deps in all project, though, in quite late time.

Thanks

On Wed, Jun 9, 2021 at 10:45 PM Jonah Graham <

jonah@xxxxxxxxxxxxxxxx

> wrote:

Hi Ondre/Nitin,

https://git.eclipse.org/r/c/simrel/org.eclipse.simrel.build/+/181738

decouples the reddeer contribution from webtools which means if you think it is ok you can merge that so reddeer can be merged.

Thanks

Jonah

~~~
Jonah Graham
Kichwa Coders

www.kichwacoders.com

On Wed, 9 Jun 2021 at 16:25, Jonah Graham <

jonah@xxxxxxxxxxxxxxxx

> wrote:

Hi Ondrej,

AFAICT the problem is that WTP is also pulling in org.slf4j 2.0 from reddeer.

15:53:01 [0]Missing requirement: Jetty :: JNDI Naming 10.0.4 (org.eclipse.jetty.jndi 10.0.4) requires 'java.package; org.slf4j [2.0.0,3.0.0)' but it could not be found

So because you are (correctly) removing slf4j 2.0, it is unintentionally breaking WTP.

Nitin is working on fixing up the WTP contribution. I don't think there is actually anything wrong with reddeer's contribution, we just need a resolution of WTP first.

I will push a patch that verifies the above in a moment.

Thanks,

Jonah

~~~
Jonah Graham
Kichwa Coders

www.kichwacoders.com

On Wed, 9 Jun 2021 at 16:15, Ondrej Dockal <

odockal@xxxxxxxxxx

> wrote:

Unfortunately, I am still not able to pass aggregator validation, this time it is jetty complaining about missing org.slf4j [2.0.0,3.0.0) as can be seen in [1]. I am not really sure about what I can do about it from my side. There is a reopened bugzilla [2] and PR on jetty project to handle this bundle dep. range for org.slf4j, but who knows when it will be fixed.

I am trying in a meantime to omit any bundles from my plugins in release, not sure if that can help.

[1]:

https://ci.eclipse.org/simrel/job/simrel.runaggregator.VALIDATE.gerrit/2274/console

[2]:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=573454

On Wed, Jun 9, 2021 at 6:47 PM Jonah Graham <

jonah@xxxxxxxxxxxxxxxx

> wrote:

Ondrej,

I think your analysis is correct. RAP tools publishes jetty to its p2 site, but does not include the slf4j so just happened to pick it up from Platform until they removed it, now it picks it up from Reddeer.

Markus,

Not sure what the issues with removing slf4j 2.0.0 alpha is. Do you mean that RAP references it in too many places? If you mean too many projects, then you might be right, but I hope not. Hopefully with rap, wtp, and reddeer making their update we can get rid of it from the 2021-06 release entirely.

Nitin,

I think the RC2 contribution of WTP only validated because Reddeer is still publishing slf4j 2.0.

Jonah

~~~
Jonah Graham
Kichwa Coders

www.kichwacoders.com

On Wed, 9 Jun 2021 at 10:55, Ondrej Dockal <

odockal@xxxxxxxxxx

> wrote:

Hi Folks,

Gerrit aggregator validation job [1] is failing for me due to RAP requiring jetty 10.0.3 and that transitively requires slf4j in 2.0.0 +, I guess I have to wait for you to update jetty deps to make it work, right?

[1]:

https://ci.eclipse.org/simrel/job/simrel.runaggregator.VALIDATE.gerrit/2247/

On Wed, Jun 9, 2021 at 4:50 PM Markus Knauer <

mknauer@xxxxxxxxxxxxxxxxx

> wrote:

Switching to Jetty 10.0.4 seems to be doable for RAP, especially because the Webtools team was so kind to give us access to their p2 repository for building. I will try that now.

slf4j 2.0.0 is a different issue. It was required until today, and is now referenced in too many places. I am not sure if it will be possible to remove it in a quick and safe manner in a last build towards RC2.

Thanks

Markus

On Wed, 9 Jun 2021 at 15:32, Jonah Graham <

jonah@xxxxxxxxxxxxxxxx

> wrote:

Hi folks,

Eclipse Platform have successfully updated their contribution

(Thanks Sravan, Thomas, Jetty team and anyone else who got this done that I don't know about!)

to SimRel to their RC2a build and that means that Eclipse Platform now no longer contributes the alpha 2.0.0 version.

However other projects still are contributing the bundle to simrel because they are republishing parts or all of Platform RC2 or earlier or jetty 10 from other sources.

Can both

reddeer

and

rap

projects look at their contribution to ensure that they are not contributing slf4j 2.0.0 alpha to the simrel please.

As Platform have updated to Jetty 10.0.4, I also see that

rap

has Jetty 10.0.3 contributed to simrel and

webtools

has 10.0.2 contributed to webtools.

All three versions

are in the simrel output repo!

Thank you,

Jonah

~~~
Jonah Graham
Kichwa Coders

www.kichwacoders.com

_______________________________________________
cross-project-issues-dev mailing list

cross-project-issues-dev@xxxxxxxxxxx